summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorArul Michael <arul71.m@gmail.com>2016-03-31 17:17:58 +0530
committerEike Rathke <erack@redhat.com>2016-03-31 15:54:06 +0000
commit527f2cd0b75f901efc683efd92a51af771b860b5 (patch)
treed47b9ea60efbd65018d089a46a1fcebde613e148
parent988847aae823c7ea47a9925f1a40cdd61cc59f5c (diff)
tdf#92963 Pasting a whole row with data crashes all open LibO apps
In ScColumn::GetNeededSize the memory pointed by rOptions.pPattern is freed and new value is set again in ScFormulaCell::InterpretTail function in pDocument->SetNumberFormat when pDocument->GetCondResult is called in column2.cxx:130.For fix setting the newly calculated ScPatternAttr* value after the GetCondResult call. Change-Id: I045404465b6dfa561b0821bb3b1875463aa7887a Reviewed-on: https://gerrit.libreoffice.org/23688 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 99bf0b931401f556033f67297aa9783c4cf19b00) Reviewed-on: https://gerrit.libreoffice.org/23709
-rw-r--r--sc/source/core/data/column2.cxx7
1 files changed, 7 insertions, 0 deletions
diff --git a/sc/source/core/data/column2.cxx b/sc/source/core/data/column2.cxx
index 8929ecd9f46e..0d4b869b49c6 100644
--- a/sc/source/core/data/column2.cxx
+++ b/sc/source/core/data/column2.cxx
@@ -127,6 +127,13 @@ long ScColumn::GetNeededSize(
// conditional formatting
const SfxItemSet* pCondSet = pDocument->GetCondResult( nCol, nRow, nTab );
+ //The pPattern may change in GetCondResult
+ if (aCell.meType == CELLTYPE_FORMULA)
+ {
+ pPattern = pAttrArray->GetPattern( nRow );
+ if (ppPatternChange)
+ *ppPatternChange = pPattern;
+ }
// line break?
const SfxPoolItem* pCondItem;