diff options
author | Arul Michael <arul71.m@gmail.com> | 2016-03-31 17:17:58 +0530 |
---|---|---|
committer | Eike Rathke <erack@redhat.com> | 2016-03-31 15:42:01 +0000 |
commit | 99bf0b931401f556033f67297aa9783c4cf19b00 (patch) | |
tree | 990c8546af5ebca4bfbc369d4aabadb6e6017869 | |
parent | 1877fc4b4154dcc48fb743e33874d321dc464ba2 (diff) |
tdf#92963 Pasting a whole row with data crashes all open LibO apps
In ScColumn::GetNeededSize the memory pointed by rOptions.pPattern is freed and
new value is set again in ScFormulaCell::InterpretTail function in pDocument->SetNumberFormat
when pDocument->GetCondResult is called in column2.cxx:130.For fix setting the newly calculated
ScPatternAttr* value after the GetCondResult call.
Change-Id: I045404465b6dfa561b0821bb3b1875463aa7887a
Reviewed-on: https://gerrit.libreoffice.org/23688
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
-rw-r--r-- | sc/source/core/data/column2.cxx | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/sc/source/core/data/column2.cxx b/sc/source/core/data/column2.cxx index b520d0ae1035..3c2986ee9812 100644 --- a/sc/source/core/data/column2.cxx +++ b/sc/source/core/data/column2.cxx @@ -129,6 +129,13 @@ long ScColumn::GetNeededSize( // conditional formatting const SfxItemSet* pCondSet = pDocument->GetCondResult( nCol, nRow, nTab ); + //The pPattern may change in GetCondResult + if (aCell.meType == CELLTYPE_FORMULA) + { + pPattern = pAttrArray->GetPattern( nRow ); + if (ppPatternChange) + *ppPatternChange = pPattern; + } // line break? const SfxPoolItem* pCondItem; |