summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRavindra Vidhate <ravindra.vidhate@synerzip.com>2014-05-22 15:39:25 +0530
committerMiklos Vajna <vmiklos@collabora.co.uk>2014-05-26 02:10:21 -0500
commit4002fae08754aec38873bc453f991773ec6536f0 (patch)
tree0eca97bdf222904c3c42a01bdf3513c97e216538
parentbce3a0a66764462a8b35df50977bd998eb904632 (diff)
fdo#79062 File having Footnote with Text Effect got corrupted after RT
When we do the export of the file, In the footnotes.xml, the w14 namespaces were not being added. This issue exists for EndNotes as well. Change-Id: I6494bbf1beaa0666743d9c1bb85a64f8bda20398 Reviewed-on: https://gerrit.libreoffice.org/9439 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
-rw-r--r--sw/qa/extras/ooxmlexport/data/fdo79062.docxbin0 -> 17422 bytes
-rw-r--r--sw/qa/extras/ooxmlexport/ooxmlexport.cxx13
-rw-r--r--sw/source/filter/ww8/docxattributeoutput.cxx5
-rw-r--r--sw/source/filter/ww8/docxexport.hxx6
4 files changed, 17 insertions, 7 deletions
diff --git a/sw/qa/extras/ooxmlexport/data/fdo79062.docx b/sw/qa/extras/ooxmlexport/data/fdo79062.docx
new file mode 100644
index 000000000000..181ea7283610
--- /dev/null
+++ b/sw/qa/extras/ooxmlexport/data/fdo79062.docx
Binary files differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport.cxx b/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
index 1d8d8900b9bf..728af1cb02a4 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
@@ -3512,6 +3512,19 @@ DECLARE_OOXMLEXPORT_TEST(testFdo78910, "fdo78910.docx")
assertXPath ( pXmlDoc, "//w:hyperlink[2]/w:r[5]/w:fldChar", "fldCharType", "end" );
}
+DECLARE_OOXMLEXPORT_TEST(testFDO79062, "fdo79062.docx")
+{
+ xmlDocPtr pXmlFootNotes = parseExport("word/footnotes.xml");
+ if (!pXmlFootNotes)
+ return;
+ assertXPath(pXmlFootNotes, "/w:footnotes", "Ignorable", "w14 wp14");
+
+ xmlDocPtr pXmlEndNotes = parseExport("word/endnotes.xml");
+ if (!pXmlEndNotes)
+ return;
+ assertXPath(pXmlEndNotes, "/w:endnotes", "Ignorable", "w14 wp14");
+}
+
DECLARE_OOXMLEXPORT_TEST(testFdo78957, "fdo78957.docx")
{
xmlDocPtr pXmlHeader = parseExport("word/header2.xml");
diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx b/sw/source/filter/ww8/docxattributeoutput.cxx
index 7539c9b1f557..2e2cb9d6c612 100644
--- a/sw/source/filter/ww8/docxattributeoutput.cxx
+++ b/sw/source/filter/ww8/docxattributeoutput.cxx
@@ -6040,10 +6040,7 @@ void DocxAttributeOutput::FootnotesEndnotes( bool bFootnotes )
sal_Int32 nBody = bFootnotes? XML_footnotes: XML_endnotes;
sal_Int32 nItem = bFootnotes? XML_footnote: XML_endnote;
- m_pSerializer->startElementNS( XML_w, nBody,
- FSNS( XML_xmlns, XML_w ), "http://schemas.openxmlformats.org/wordprocessingml/2006/main",
- FSNS( XML_xmlns, XML_r ), "http://schemas.openxmlformats.org/officeDocument/2006/relationships",
- FSEND );
+ m_pSerializer->startElementNS( XML_w, nBody, m_rExport.MainXmlNamespaces(m_pSerializer) );
sal_Int32 nIndex = 0;
diff --git a/sw/source/filter/ww8/docxexport.hxx b/sw/source/filter/ww8/docxexport.hxx
index cd5450ed7cc4..950db249f066 100644
--- a/sw/source/filter/ww8/docxexport.hxx
+++ b/sw/source/filter/ww8/docxexport.hxx
@@ -246,9 +246,6 @@ private:
/// Write word/embeddings/Worksheet[n].xlsx
void WriteEmbeddings();
- /// All xml namespaces to be used at the top of any text .xml file (main doc, headers, footers,...)
- sax_fastparser::XFastAttributeListRef MainXmlNamespaces( sax_fastparser::FSHelperPtr serializer );
-
/// Get background color of the document, if there is one.
boost::optional<const SvxBrushItem*> getBackground();
@@ -256,6 +253,9 @@ private:
bool isMirroredMargin();
public:
+ /// All xml namespaces to be used at the top of any text .xml file (main doc, headers, footers,...)
+ sax_fastparser::XFastAttributeListRef MainXmlNamespaces( sax_fastparser::FSHelperPtr serializer );
+
/// FIXME this is temporary, remotely reminding the method of the same
/// name in WW8Export.
void WriteMainText();