summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Tardon <dtardon@redhat.com>2016-05-03 14:49:34 +0200
committerDavid Tardon <dtardon@redhat.com>2016-05-03 15:34:09 +0200
commit390ddd3bde617388e481b6747aa7bbea17d5ddf1 (patch)
treed8dace9ed823e6e822f54f31cbc468bd1e97a0db
parent0b1e4a306705d8c25db6e233244101ba6c4c16b6 (diff)
tdf#99353 take the footgun away from FilterCache
FilterCache::impl_saveItem changes the properties of a config. item one-by-one. But it also listens to the configuration changes and reloads the whole item from the configuration on change... Change-Id: I9e4ed1c6b013925d07f0942717fe3421f924279d
-rw-r--r--filter/source/config/cache/filtercache.cxx2
-rw-r--r--filter/source/config/cache/filtercache.hxx2
2 files changed, 2 insertions, 2 deletions
diff --git a/filter/source/config/cache/filtercache.cxx b/filter/source/config/cache/filtercache.cxx
index b9d15cf94f39..6f5616d70369 100644
--- a/filter/source/config/cache/filtercache.cxx
+++ b/filter/source/config/cache/filtercache.cxx
@@ -1786,7 +1786,7 @@ CacheItemList::iterator FilterCache::impl_loadItemOnDemand( EItemType
void FilterCache::impl_saveItem(const css::uno::Reference< css::container::XNameReplace >& xItem,
EItemType eType,
- const CacheItem& aItem)
+ const CacheItem aItem)
throw(css::uno::Exception)
{
CacheItem::const_iterator pIt;
diff --git a/filter/source/config/cache/filtercache.hxx b/filter/source/config/cache/filtercache.hxx
index 93c8d78e07a8..4f8b0637ab69 100644
--- a/filter/source/config/cache/filtercache.hxx
+++ b/filter/source/config/cache/filtercache.hxx
@@ -809,7 +809,7 @@ class FilterCache : public BaseLock
/** TODO */
static void impl_saveItem(const css::uno::Reference< css::container::XNameReplace >& xSet ,
EItemType eType ,
- const CacheItem& aValue)
+ const CacheItem aValue)
throw(css::uno::Exception);