summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNoel Grandin <noel.grandin@collabora.co.uk>2018-04-23 10:18:31 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2018-04-24 08:21:56 +0200
commit27bc42d77a71118b9e7cf11132ea4e47d42b676c (patch)
tree2df1cdb64d990eec4fadd89a9cd4fff0ee1203bd
parent148b84160667ed3ec74c8767f6e62567479488f9 (diff)
loplugin:useuniqueptr in TextWindow
Change-Id: I66c966f79d56be5dfc1422fa3de52d9bf4411ff2 Reviewed-on: https://gerrit.libreoffice.org/53348 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-rw-r--r--include/vcl/vclmedit.hxx8
-rw-r--r--vcl/source/edit/vclmedit.cxx12
2 files changed, 9 insertions, 11 deletions
diff --git a/include/vcl/vclmedit.hxx b/include/vcl/vclmedit.hxx
index 6b4b0b8fcebb..eaffca059a0d 100644
--- a/include/vcl/vclmedit.hxx
+++ b/include/vcl/vclmedit.hxx
@@ -36,8 +36,8 @@ class TextWindow : public vcl::Window
{
private:
VclPtr<Edit> mxParent;
- ExtTextEngine* mpExtTextEngine;
- TextView* mpExtTextView;
+ std::unique_ptr<ExtTextEngine> mpExtTextEngine;
+ std::unique_ptr<TextView> mpExtTextView;
bool mbInMBDown;
bool mbFocusSelectionHide;
@@ -50,8 +50,8 @@ public:
virtual ~TextWindow() override;
virtual void dispose() override;
- ExtTextEngine* GetTextEngine() const { return mpExtTextEngine; }
- TextView* GetTextView() const { return mpExtTextView; }
+ ExtTextEngine* GetTextEngine() const { return mpExtTextEngine.get(); }
+ TextView* GetTextView() const { return mpExtTextView.get(); }
virtual void MouseMove( const MouseEvent& rMEvt ) override;
virtual void MouseButtonDown( const MouseEvent& rMEvt ) override;
diff --git a/vcl/source/edit/vclmedit.cxx b/vcl/source/edit/vclmedit.cxx
index 32a2b209696e..18a48eddb933 100644
--- a/vcl/source/edit/vclmedit.cxx
+++ b/vcl/source/edit/vclmedit.cxx
@@ -672,13 +672,13 @@ TextWindow::TextWindow(Edit* pParent)
SetPointer( Pointer( PointerStyle::Text ) );
- mpExtTextEngine = new ExtTextEngine;
+ mpExtTextEngine.reset(new ExtTextEngine);
mpExtTextEngine->SetMaxTextLen(EDIT_NOLIMIT);
if( pParent->GetStyle() & WB_BORDER )
mpExtTextEngine->SetLeftMargin( 2 );
mpExtTextEngine->SetLocale( GetSettings().GetLanguageTag().getLocale() );
- mpExtTextView = new TextView( mpExtTextEngine, this );
- mpExtTextEngine->InsertView( mpExtTextView );
+ mpExtTextView.reset(new TextView( mpExtTextEngine.get(), this ));
+ mpExtTextEngine->InsertView( mpExtTextView.get() );
mpExtTextEngine->EnableUndo( true );
mpExtTextView->ShowCursor();
@@ -695,10 +695,8 @@ TextWindow::~TextWindow()
void TextWindow::dispose()
{
mxParent.clear();
- delete mpExtTextView;
- mpExtTextView = nullptr;
- delete mpExtTextEngine;
- mpExtTextEngine = nullptr;
+ mpExtTextView.reset();
+ mpExtTextEngine.reset();
Window::dispose();
}