summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNoel Grandin <noel.grandin@collabora.co.uk>2019-10-18 15:40:37 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2019-10-21 18:13:44 +0200
commit1acc7c2fe72a48db0590a57ad447a47eb9d8a62e (patch)
tree90425f5c67195a735e60cfc059cf4ba7d5d219d8
parentc219bcdc1ef4972f67e994ce153e21c144e636e9 (diff)
loplugin:virtualdead unused params in forms
Change-Id: Iac26ba57443060474f4f33c4f449a69eca8c1063 Reviewed-on: https://gerrit.libreoffice.org/81236 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-rw-r--r--compilerplugins/clang/virtualdead.unusedparams.results6
-rw-r--r--forms/source/richtext/attributedispatcher.cxx2
-rw-r--r--forms/source/richtext/attributedispatcher.hxx2
-rw-r--r--forms/source/richtext/richtextcontrol.cxx2
-rw-r--r--forms/source/richtext/richtextcontrol.hxx2
-rw-r--r--forms/source/richtext/richtextimplcontrol.cxx6
-rw-r--r--forms/source/richtext/textattributelistener.hxx4
7 files changed, 9 insertions, 15 deletions
diff --git a/compilerplugins/clang/virtualdead.unusedparams.results b/compilerplugins/clang/virtualdead.unusedparams.results
index 685ee43e2b3c..e4f4db66e909 100644
--- a/compilerplugins/clang/virtualdead.unusedparams.results
+++ b/compilerplugins/clang/virtualdead.unusedparams.results
@@ -67,12 +67,6 @@ extensions/source/bibliography/loadlisteneradapter.hxx:110
extensions/source/bibliography/loadlisteneradapter.hxx:111
void bib::OLoadListener::_reloading(const struct com::sun::star::lang::EventObject &,)
0
-forms/source/richtext/textattributelistener.hxx:32
- void frm::ITextAttributeListener::onAttributeStateChanged(int,const struct frm::AttributeState &,)
- 10
-forms/source/richtext/textattributelistener.hxx:44
- void frm::ITextSelectionListener::onSelectionChanged(const struct ESelection &,)
- 0
include/canvas/base/bufferedgraphicdevicebase.hxx:230
void canvas::BufferedGraphicDeviceBase::windowShown(const struct com::sun::star::lang::EventObject &,)
0
diff --git a/forms/source/richtext/attributedispatcher.cxx b/forms/source/richtext/attributedispatcher.cxx
index dd81f3129cc7..0cabb526c75f 100644
--- a/forms/source/richtext/attributedispatcher.cxx
+++ b/forms/source/richtext/attributedispatcher.cxx
@@ -98,7 +98,7 @@ namespace frm
}
- void OAttributeDispatcher::onAttributeStateChanged( AttributeId _nAttributeId, const AttributeState& /*_rState*/ )
+ void OAttributeDispatcher::onAttributeStateChanged( AttributeId _nAttributeId )
{
OSL_ENSURE( _nAttributeId == m_nAttributeId, "OAttributeDispatcher::onAttributeStateChanged: wrong attribute!" );
diff --git a/forms/source/richtext/attributedispatcher.hxx b/forms/source/richtext/attributedispatcher.hxx
index 42a673209da1..685825f5c88f 100644
--- a/forms/source/richtext/attributedispatcher.hxx
+++ b/forms/source/richtext/attributedispatcher.hxx
@@ -61,7 +61,7 @@ namespace frm
virtual void SAL_CALL dispatch( const css::util::URL& URL, const css::uno::Sequence< css::beans::PropertyValue >& Arguments ) override;
// ITextAttributeListener
- virtual void onAttributeStateChanged( AttributeId _nAttributeId, const AttributeState& _rState ) override;
+ virtual void onAttributeStateChanged( AttributeId _nAttributeId ) override;
// ORichTextFeatureDispatcher
virtual void disposing( ::osl::ClearableMutexGuard& _rClearBeforeNotify ) override;
diff --git a/forms/source/richtext/richtextcontrol.cxx b/forms/source/richtext/richtextcontrol.cxx
index 7e1b9bebcfd9..810d8e50c860 100644
--- a/forms/source/richtext/richtextcontrol.cxx
+++ b/forms/source/richtext/richtextcontrol.cxx
@@ -635,7 +635,7 @@ namespace frm
}
- void ORichTextPeer::onSelectionChanged( const ESelection& /*_rSelection*/ )
+ void ORichTextPeer::onSelectionChanged()
{
AttributeDispatchers::iterator aDispatcherPos = m_aDispatchers.find( SID_COPY );
if ( aDispatcherPos != m_aDispatchers.end() )
diff --git a/forms/source/richtext/richtextcontrol.hxx b/forms/source/richtext/richtextcontrol.hxx
index 0c552848df5b..94aa8ce54e7c 100644
--- a/forms/source/richtext/richtextcontrol.hxx
+++ b/forms/source/richtext/richtextcontrol.hxx
@@ -117,7 +117,7 @@ namespace frm
virtual css::uno::Sequence< css::uno::Reference< css::frame::XDispatch > > SAL_CALL queryDispatches( const css::uno::Sequence< css::frame::DispatchDescriptor >& Requests ) override;
// ITextSelectionListener
- virtual void onSelectionChanged( const ESelection& _rSelection ) override;
+ virtual void onSelectionChanged() override;
private:
SingleAttributeDispatcher implCreateDispatcher( SfxSlotId _nSlotId, const css::util::URL& _rURL );
diff --git a/forms/source/richtext/richtextimplcontrol.cxx b/forms/source/richtext/richtextimplcontrol.cxx
index 2aeedc11d2ef..844ba9d6e119 100644
--- a/forms/source/richtext/richtextimplcontrol.cxx
+++ b/forms/source/richtext/richtextimplcontrol.cxx
@@ -152,7 +152,7 @@ namespace frm
if ( aCurrentSelection != m_aLastKnownSelection )
{
m_aLastKnownSelection = aCurrentSelection;
- m_pSelectionListener->onSelectionChanged( m_aLastKnownSelection );
+ m_pSelectionListener->onSelectionChanged();
}
}
}
@@ -255,11 +255,11 @@ namespace frm
// is there a dedicated listener for this particular attribute?
AttributeListenerPool::const_iterator aListenerPos = m_aAttributeListeners.find( _nAttribute );
if ( aListenerPos != m_aAttributeListeners.end( ) )
- aListenerPos->second->onAttributeStateChanged( _nAttribute, _rState );
+ aListenerPos->second->onAttributeStateChanged( _nAttribute );
// call our global listener, if there is one
if ( m_pTextAttrListener )
- m_pTextAttrListener->onAttributeStateChanged( _nAttribute, _rState );
+ m_pTextAttrListener->onAttributeStateChanged( _nAttribute );
}
diff --git a/forms/source/richtext/textattributelistener.hxx b/forms/source/richtext/textattributelistener.hxx
index 0593c49968ef..c33ccbc0f932 100644
--- a/forms/source/richtext/textattributelistener.hxx
+++ b/forms/source/richtext/textattributelistener.hxx
@@ -29,7 +29,7 @@ namespace frm
class ITextAttributeListener
{
public:
- virtual void onAttributeStateChanged( AttributeId _nAttributeId, const AttributeState& _rState ) = 0;
+ virtual void onAttributeStateChanged( AttributeId _nAttributeId ) = 0;
protected:
~ITextAttributeListener() {}
@@ -41,7 +41,7 @@ namespace frm
class ITextSelectionListener
{
public:
- virtual void onSelectionChanged( const ESelection& _rSelection ) = 0;
+ virtual void onSelectionChanged() = 0;
protected:
~ITextSelectionListener() {}