diff options
| author | Eike Rathke <erack@redhat.com> | 2017-12-15 16:27:54 +0100 |
|---|---|---|
| committer | Eike Rathke <erack@redhat.com> | 2017-12-15 19:34:09 +0100 |
| commit | 1aa8011d9186dc4d221469058a9fcaf5a93ae765 (patch) | |
| tree | b93e4f74315b0b949260a4cdd9e8ee0303355020 | |
| parent | 5769b301dc307d2019faf1a480b930182d03ba54 (diff) | |
Resolves: tdf#113537 don't keep nEndRow=MAXROW if data ends above
Change-Id: I186034cada9718c067fa4dc7f72e2ca55ac06f83
(cherry picked from commit fa100e0abc83b876ca18b4178c44fb1dfc452a5d)
Reviewed-on: https://gerrit.libreoffice.org/46565
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
| -rw-r--r-- | sc/source/core/tool/dbdata.cxx | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/sc/source/core/tool/dbdata.cxx b/sc/source/core/tool/dbdata.cxx index 020b2daed980..0b7ebd3b6bfe 100644 --- a/sc/source/core/tool/dbdata.cxx +++ b/sc/source/core/tool/dbdata.cxx @@ -624,7 +624,12 @@ void ScDBData::ExtendDataArea(const ScDocument* pDoc) SCCOL nOldCol1 = nStartCol, nOldCol2 = nEndCol; SCROW nOldEndRow = nEndRow; pDoc->GetDataArea(nTable, nStartCol, nStartRow, nEndCol, nEndRow, false, true); - nEndRow = std::max(nEndRow, nOldEndRow); + // nOldEndRow==MAXROW may easily happen when selecting whole columns and + // setting an AutoFilter (i.e. creating an anonymous database-range). We + // certainly don't want to iterate over nearly a million empty cells, but + // keep only an intentionally user selected range. + if (nOldEndRow < MAXROW && nEndRow < nOldEndRow) + nEndRow = nOldEndRow; if (nStartCol != nOldCol1 || nEndCol != nOldCol2) { SAL_WARN_IF( !maTableColumnNames.empty(), "sc.core", "ScDBData::ExtendDataArea - invalidating column names/offsets"); |