summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStefan Kost <ensonic@users.sf.net>2009-06-04 17:37:03 +0300
committerStefan Kost <ensonic@users.sf.net>2009-06-04 17:43:15 +0300
commit85ba1b3e6a7af72c74d1ed788bb9f9bf0537fabf (patch)
tree6825558af656526ed9f861a4b37c84692e85047b
parentb9ddf22340b2d0c76bb0b77a4b8976ed339b1cd8 (diff)
pulsesink: only notify if all checks passed
Replace goto done: with return, as those are checks when we don't want to flag a pending notify.
-rw-r--r--ext/pulse/pulsesink.c7
1 files changed, 3 insertions, 4 deletions
diff --git a/ext/pulse/pulsesink.c b/ext/pulse/pulsesink.c
index 36d5b1b1e..fd349e731 100644
--- a/ext/pulse/pulsesink.c
+++ b/ext/pulse/pulsesink.c
@@ -315,20 +315,19 @@ gst_pulsering_context_subscribe_cb (pa_context * c,
if (t != (PA_SUBSCRIPTION_EVENT_SINK_INPUT | PA_SUBSCRIPTION_EVENT_CHANGE) &&
t != (PA_SUBSCRIPTION_EVENT_SINK_INPUT | PA_SUBSCRIPTION_EVENT_NEW))
- goto done;
+ return;
if (!pbuf->stream)
- goto done;
+ return;
if (idx != pa_stream_get_index (pbuf->stream))
- goto done;
+ return;
/* Actually this event is also triggered when other properties of
* the stream change that are unrelated to the volume. However it is
* probably cheaper to signal the change here and check for the
* volume when the GObject property is read instead of querying it always. */
-done:
/* inform streaming thread to notify */
g_atomic_int_compare_and_exchange (&psink->notify, 0, 1);
}