summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStefan Kost <ensonic@users.sf.net>2010-02-16 10:10:45 +0200
committerStefan Kost <ensonic@users.sf.net>2010-02-16 10:15:22 +0200
commit45522aab4691501ad9db7828ad539111375679ac (patch)
tree960f97cff616885f481c94eee3215fc2f1151e99
parenta45b351ddf48dc876e8e0ee69575480b57ab3e96 (diff)
jpegenc: add a fixme for handling other YUV variants
-rw-r--r--ext/jpeg/gstjpegenc.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/ext/jpeg/gstjpegenc.c b/ext/jpeg/gstjpegenc.c
index 73e674c9e..01f1665a2 100644
--- a/ext/jpeg/gstjpegenc.c
+++ b/ext/jpeg/gstjpegenc.c
@@ -514,6 +514,11 @@ gst_jpegenc_chain (GstPad * pad, GstBuffer * buf)
end[1] = base[1] + (height / 2) * I420_U_ROWSTRIDE (width);
end[2] = base[2] + (height / 2) * I420_V_ROWSTRIDE (width);
+ /* FIXME: shouldn't we also set
+ * - jpegenc->cinfo.max_{v,h}_samp_factor
+ * - jpegenc->cinfo.comp_info[0,1,2].{v,h}_samp_factor
+ * accordingly?
+ */
jpegenc->jdest.next_output_byte = GST_BUFFER_DATA (jpegenc->output_buffer);
jpegenc->jdest.free_in_buffer = GST_BUFFER_SIZE (jpegenc->output_buffer);