summaryrefslogtreecommitdiff
path: root/cli
AgeCommit message (Collapse)AuthorFilesLines
2014-04-03fix typos in documentation and messagesYuri Chornoivan1-3/+3
https://bugzilla.gnome.org/show_bug.cgi?id=727031 Signed-off-by: Thomas Haller <thaller@redhat.com>
2014-04-02cli: fix setting DCB application priority (rh #1080510)Dan Williams1-4/+4
Priority was originally a 'guint' but then got changed to 'gint' and apparently we forgot to fix one place up.
2014-04-01nmcli: use correct Mbit/s units for maximal bitrate (rh #1080474)Jiří Klimeš1-1/+1
https://bugzilla.redhat.com/show_bug.cgi?id=1080474
2014-03-31nmcli: fix an error when showing progress of activation in editorJiří Klimeš1-6/+13
(process:7213): CRITICAL **: nm_active_connectiuon_get_state: assertion `NM_IS_ACTIVE_CONNECTION (connection)' failed
2014-03-17cli: fix bridge priority default value (rh #1073664)Jiří Klimeš1-2/+2
It is 32768 (0x8000) instead of 128 (0x80). 13c348d fixes that in the setting. https://bugzilla.redhat.com/show_bug.cgi?id=1073664
2014-03-12cli: sanitize team config before setting it into propertyJiří Klimeš1-1/+12
Replace '\r' and '\n' chareacter with a space in the configuration. libteamdctl sends the config to team daemon using its usock interface that separates parameters with '\n'. Related: rh #1051517
2014-03-12cli: accept prefix "ifname/", "uuid/" or "id/" for 'master' argumentJiří Klimeš1-12/+50
nmcli con add type team-slave ifname em2 master team-master0 nmcli con add type team-slave ifname em2 master id/team-master0 It helps to disambiguate values for cases where they may overlap, e.g. "team0" -> "ifname/team0" or "id/team0"
2014-03-12cli: allow specifying 'master' for slaves as connection ID (rh #1057494)Jiří Klimeš1-12/+69
nmcli con add type *-slave ifname em1 master <ifname|UUID|name> 'master' property of 'connection' setting has to be either interface name or connection UUID of master connection. However, to make nmcli more convenient for users, we also allow specifying connection name and translating it to UUID automatically. https://bugzilla.redhat.com/show_bug.cgi?id=1057494
2014-03-03cli: fix a crash when trying to set a white-space string as IP (rh #1071394)Jiří Klimeš1-18/+22
nmcli con modify my-profile ipv4.addr " " nmcli con modify my-profile ipv6.addr " " Note: Empty string should be used to remove IPs, and 'method' might be needed to set to 'auto' simultaneously, as well. $ nmcli con modify profile1 ipv4.addr "" ipv4.method auto https://bugzilla.redhat.com/show_bug.cgi?id=1071394
2014-03-02cli/bash-completion: fix `nmcli connection CMD` completion for --help optionThomas Haller1-10/+108
The --help option (or its aliases -help/help) is only allowed at as first argument. Fix completion to account for this. Signed-off-by: Thomas Haller <thaller@redhat.com>
2014-03-01cli/bash-completion: only allow --help as first argument for nmcli ↵Thomas Haller1-18/+47
connection modify Signed-off-by: Thomas Haller <thaller@redhat.com>
2014-03-01cli/bash-completion: use printf instead of echo (because echo inteprets some ↵Thomas Haller1-7/+4
--options) Signed-off-by: Thomas Haller <thaller@redhat.com>
2014-03-01cli/bash-completion: simplify code by passing arrays by indirection to functionsThomas Haller1-57/+76
Signed-off-by: Thomas Haller <thaller@redhat.com>
2014-02-28cli/bash-completion: complete more then one connections for `nmcli ↵Thomas Haller1-1/+19
connection delete` Signed-off-by: Thomas Haller <thaller@redhat.com>
2014-02-28cli/bash-completion: complete more then one properties for `nmcli connection ↵Thomas Haller1-3/+11
modify` Signed-off-by: Thomas Haller <thaller@redhat.com>
2014-02-28cli/bash-completion: complet nmcli connection modify --temporaryThomas Haller1-1/+20
Signed-off-by: Thomas Haller <thaller@redhat.com>
2014-02-28cli/bash-completion: support abbreviated options for commandsThomas Haller1-4/+12
Add support for abbreviated options as first argument: nmcli connection show --act <TAB> Signed-off-by: Thomas Haller <thaller@redhat.com>
2014-02-28cli/bash-completion: support abbreviations for optionsThomas Haller1-40/+70
Signed-off-by: Thomas Haller <thaller@redhat.com>
2014-02-28cli: update 'nmcli con modify' helpJiří Klimeš1-2/+3
2014-02-28cli: update 'remove' command description for 'nmcli con edit'Jiří Klimeš1-5/+12
to reflect that user can specify a value or index to remove values.
2014-02-28cli: allow removing properties by-value (in addition to by-index)Jiří Klimeš1-156/+592
It works both in 'nmcli con modify' and 'nmcli con edit'. The following properties are supported (all container-type properties except properties with option names): ipv4.dns ipv4.dns-searches ipv4.addresses ipv4.routes ipv6.dns ipv6.dns-searches ipv6.addresses ipv6.routes 802-1x.eap 802-1x.altsubject-matches 802-1x.phase2-altsubject-matches connection.permissions connection.secondary 802-3-ethernet.mac-address-blacklist 802-11-wireless.mac-address-blacklist 802-11-wireless-security.proto 802-11-wireless-security.pairwise 802-11-wireless-security.group vlan.ingress-priority-map vlan.egress-priority-map
2014-02-28cli: support removing items from container-type properties in 'nmcli con modify'Jiří Klimeš1-13/+44
Synopsis: nmcli con modify -<property>.<setting> <value> 'value' can be empty ("") to remove the whole property value value (in this case the behaviour is the same as without '-'). Or the 'value' is an index of the item to remove, or an option name (for a few properties that have option names, like bond.options or ethernet.s390-options). $ nmcli con mod myeth ipv4.dns "10.0.0.55 10.0.0.66 8.8.8.8 8.8.4.4" ---> ipv4.dns: 10.0.0.55, 10.0.0.66, 8.8.8.8, 8.8.4.4 $ nmcli con mod myeth -ipv4.dns 1 ---> ipv4.dns: 10.0.0.55, 8.8.8.8, 8.8.4.4 ---> bond.options: mode=balance-rr $ nmcli con mod bond0 +bond.options "mii=500, downdelay=800" ---> bond.options: downdelay=800,miimon=500,mode=balance-rr $ nmcli con mod bond0 -bond.options downdelay ---> bond.options: miimon=500,mode=balance-rr
2014-02-28cli: allow modifying multiple properties by 'nmcli con modify'Jiří Klimeš1-72/+100
This is necessary especially for cases where properties depend on each other. So you need to set them in one command, else the profile won't validate. Examples: nmcli con mod em1-1 ipv4.method manual ipv4.addr "192.168.1.2/24,10.10.1.5/8" nmcli con mod profile ipv4.method link-local ipv4.addr ""
2014-02-28cli: set vs. append property value by 'nmcli con modify' (rh #1044027)Jiří Klimeš1-4/+19
Previously 'nmcli con modify' appended values for multi-value properties. This commit makes 'nmcli con modify' overwrite the whole value. You can choose appending values by prefixing the setting.property with '+' sign. For simple (not container) properties the behaviour is the same both with and without the '+', of course. Synopsis: nmcli connection modify [+]<setting>.<property <value> Example: ---> ipv4.dns = 1.2.3.4 $ nmcli connection modify my-em1 ipv4.dns 8.8.8.8 ---> ipv4.dns = 8.8.8.8 $ nmcli connection modify my-em1 +ipv4.dns 8.8.4.4 ---> ipv4.dns = 8.8.8.8 8.8.4.4 https://bugzilla.redhat.com/show_bug.cgi?id=1044027
2014-02-28cli: allow temporary connection modification by 'nmcli con modify'Jiří Klimeš1-6/+11
nmcli connection modify [--temporary] ...
2014-02-27trivial: more wrong compiler warningsThomas Haller1-1/+1
connection_parser.c: In function 'make_ip4_setting': connection_parser.c:660:33: error: 'method' may be used uninitialized in this function [-Werror=maybe-uninitialized] if (!is_static_block && strstr (method, "dhcp")) { connections.c: In function ‘load_cmd_line_edit_lib’: connections.c:5744:17: error: ‘module’ may be used uninitialized in this function [-Werror=maybe-uninitialized] g_module_close (module); Signed-off-by: Thomas Haller <thaller@redhat.com>
2014-02-24replace snprintf by g_snprintfThomas Haller1-2/+1
Use the glib wrapper for snprintf. Signed-off-by: Thomas Haller <thaller@redhat.com>
2014-02-24cli: allow resetting the connection.master to NULLThomas Haller1-2/+6
Without this patch, the following two commands fail: nmcli connection modify em1 connection.master nmcli connection modify em1 connection.master "" Signed-off-by: Thomas Haller <thaller@redhat.com>
2014-02-17cli: better checking of WEP key types in nmcli interactive editor (rh #1040964)Jiří Klimeš1-11/+54
https://bugzilla.redhat.com/show_bug.cgi?id=1040964
2014-02-13libnm-util, libnm-glib: add versioned deprecation/availability macrosDan Winship1-0/+1
Add versioned NM_DEPRECATED_IN_* and NM_AVAILABLE_IN_* macros, and tag new/deprecated functions accordingly. (All currently-deprecated functions are assumed to have been deprecated in 0.9.10.) Add NM_VERSION_MIN_REQUIRED and NM_VERSION_MAX_ALLOWED macros which can be set to determine which versions will cause warnings. With the current settings, external consumers of the libnm-util/libnm-glib APIs will have MIN_REQUIRED and MAX_ALLOWED both set to NM_VERSION_0_9_8 by default, meaning they will get warnings about functions added in 0.9.10. NM internally sets NM_VERSION_MAX_ALLOWED to NM_VERSION_NEXT_STABLE to ensure that it is always allowed to use all APIs.
2014-02-13cli: show warning when setting band/channel for infra mode (rh #1000096)Thomas Haller3-4/+60
The band/channel property is not considered when connecting to an access point. Print a warning, when setting one of these values in edit mode. For now, don't forbid the user to make such setting. Also, because in the future, wpa_supplicant might support this. https://bugzilla.redhat.com/show_bug.cgi?id=999997 https://bugzilla.redhat.com/show_bug.cgi?id=1000096 Signed-off-by: Thomas Haller <thaller@redhat.com>
2014-02-12cli: fix crash if active connection doesn't have a device (rh #1064333)Jiří Klimeš1-7/+13
$ nmcli dev connect wlan0 This can happen for example when some other process disconnects the connection being connected. Also fix printing a message on success. https://bugzilla.redhat.com/show_bug.cgi?id=1064333
2014-01-30cli/bash-completion: make 'ifname' a mandatory parameter for `nmcli ↵Thomas Haller1-3/+27
connection add` For some connection types (bond, bridge, team and vlan), 'ifname' is optional. Signed-off-by: Thomas Haller <thaller@redhat.com>
2014-01-30cli/bash-completion: complete 'save' option for `nmcli connection add`Thomas Haller1-1/+2
Signed-off-by: Thomas Haller <thaller@redhat.com>
2014-01-30cli: persistent vs. temporary save for 'nmcli con edit'Jiří Klimeš1-16/+65
2014-01-30cli: allow creating temporary (unsaved) connection with 'nmcli con add'Jiří Klimeš1-4/+32
2014-01-23cli: handle hidden-SSID access points correctlyDan Williams1-11/+17
2014-01-23cli/bash-completion: update completion for new `nmcli connection show` syntaxThomas Haller1-39/+40
As nmcli changes the syntax for the 'connection show' command, this patch for bash completion also breaks several cases when completing for an old nmcli command. Signed-off-by: Thomas Haller <thaller@redhat.com>
2014-01-23cli: allow processing all connections with the same nameJiří Klimeš1-22/+61
When there are multiple connection profiles of the same name, we used to take and process only the first one. We change the behaviour to process all the connections now in these commands: nmcli connection show <duplicated name> nmcli connection down <duplicated name> nmcli connection delete <duplicated name>
2014-01-23cli: consolidate active and configured connections (rh #997999)Jiří Klimeš3-325/+528
Handle connection profiles in a single 'show' command instead of 'show active' and 'show configured'. nmcli con show [--active] [[id|uuid|path|apath] <bla>] nmcli con show : display all connection profiles nmcli con show --active : only display active connection profiles (filters out inactive profiles) nmcli con show myeth : display details of "myeth" profile, and also active connection info (if the profile is active) nmcli -f profile con show myeth : only display "myeth"'s static configuration nmcli -f active con show myeth : only display active details of "myeth" nmcli -f connection.id,ipv4,general con show myeth : display "connection.id"a property "ipv4" setting and "GENERAL" group of active data https://bugzilla.redhat.com/show_bug.cgi?id=997999
2014-01-21cli: always get up-to-date dirty statusJiří Klimeš1-10/+13
2014-01-21cli: fix crash when edited profile was removed by another client (rh #1011942)Jiří Klimeš1-12/+57
Use g_weak_ref_get() that either returns an object with reference increment or returns NULL. That fixes the problem. However, in the long run we should rework the editor loop trying to merge that with GMainLoop, which could help for various issues. https://bugzilla.redhat.com/show_bug.cgi?id=1011942
2014-01-20cli: fix TAB-completion and 'goto' after saving connectionJiří Klimeš1-3/+15
On 'save' we replace settings in the local connection, so we also need to update stored setting pointers.
2014-01-16trivial: annotate/adjust some code to appease CoverityDan Winship1-1/+1
2014-01-10cli: fix printing error on incorrect 'nmcli -f blah dev show'Jiří Klimeš1-3/+8
Don't print extra empty lines before the error.
2014-01-10cli/bash-completion: trivial rename of functionsThomas Haller1-45/+45
Signed-off-by: Thomas Haller <thaller@redhat.com>
2014-01-10cli/bash-completion: add second level help optionThomas Haller1-15/+35
Commands now support help at the second level. Add completion for it. Signed-off-by: Thomas Haller <thaller@redhat.com>
2014-01-10cli/bash-completion: only complete active connections for `nmcli con down`Thomas Haller1-2/+7
Only complete the ids/uuids for active connections in `nmcli connection down <type> <TAB>`. Signed-off-by: Thomas Haller <thaller@redhat.com>
2014-01-10cli/bash-completion: cleanup/refactor by making functions genericThomas Haller1-72/+28
Instead of having several bash functions that return some values via nmcli, add few functions that accept parameters. Signed-off-by: Thomas Haller <thaller@redhat.com>
2014-01-10cli/bash-completion: fix wrong completion for `nmcli device wimax`Thomas Haller1-18/+0
wimax does not support these arguments. This was a copy&paste error from wifi. Signed-off-by: Thomas Haller <thaller@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-13 23:22:58 +0000