summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Haller <thaller@redhat.com>2023-03-30 14:41:31 +0200
committerThomas Haller <thaller@redhat.com>2023-03-30 14:56:14 +0200
commit15c25e91f5a59d284ef99053bcb695c9843c5e31 (patch)
treeae2172021cc8712b9a24e5975d9a05fd307bcd4c
parent9ed802b0c289ec785efb23e76272e61466242d8b (diff)
client/tests: skip cloud-setup test for older python
The test uses subprocess.Popen()'s "pass_fd" argument. That is only available since Python 3.2. Possibly it could be solved differently, but that is not implemented. Instead, skip the test. Also, socket.socket.set_inheritable() is Python 3.4. But presumably we don't need it. Fixes: d89d42bf2317 ('tests/client: test nm-cloud-setup')
-rwxr-xr-xsrc/tests/client/test-client.py4
1 files changed, 4 insertions, 0 deletions
diff --git a/src/tests/client/test-client.py b/src/tests/client/test-client.py
index e603203e3e..31cfbb0e1e 100755
--- a/src/tests/client/test-client.py
+++ b/src/tests/client/test-client.py
@@ -2146,6 +2146,10 @@ class TestNmCloudSetup(TestNmClient):
if pexpect is None:
raise unittest.SkipTest("pexpect not available")
+ if tuple(sys.version_info[0:2]) < (3, 2):
+ # subprocess.Popen()'s "pass_fd" argument requires at least Python 3.2.
+ raise unittest.SkipTest("This test requires at least Python 3.2")
+
s = socket.socket()
s.set_inheritable(True)
s.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)