summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAleksander Morgado <aleksandermj@chromium.org>2023-10-17 21:45:35 +0000
committerAleksander Morgado <aleksandermj@chromium.org>2023-10-17 21:50:21 +0000
commit616df80418612fa9e0f78d34049767e118d60204 (patch)
treea8e6bcf2856af661e946ca9ab0de8d9f2ac419c3
parent334329ec38149a3937551efa0b3a7a37e4547f46 (diff)
ublox: remove ID_MM_PROCESS tagsmm-1-22
The ID_MM_PROCESS tag should be set by the user when using the allowlist filter, we must not ship any device flagged by default with that tag. Moreover, the two ENV actions in a single rule is something not currently supported by the builtin udev rule parser that is used in systems without udev (e.g. openwrt). Fixes https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/issues/779 (cherry picked from commit 16b8b6a08f1a58bf59533b2e138590dd449b733f)
-rw-r--r--src/plugins/ublox/77-mm-ublox-port-types.rules4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/plugins/ublox/77-mm-ublox-port-types.rules b/src/plugins/ublox/77-mm-ublox-port-types.rules
index f478464e..d4365c48 100644
--- a/src/plugins/ublox/77-mm-ublox-port-types.rules
+++ b/src/plugins/ublox/77-mm-ublox-port-types.rules
@@ -88,8 +88,8 @@ SUBSYSTEMS=="usb", ATTRS{bInterfaceNumber}=="?*", ENV{.MM_USBIFNUM}="$attr{bInte
# ttyUSB2 (if #2): secondary
# ttyUSB3 (if #3): unused (ignore)
ATTRS{idVendor}=="05c6", ATTRS{idProduct}=="908b", ENV{.MM_USBIFNUM}=="00", ENV{ID_MM_PORT_IGNORE}="1"
-ATTRS{idVendor}=="05c6", ATTRS{idProduct}=="908b", ENV{.MM_USBIFNUM}=="01", ENV{ID_MM_PORT_TYPE_AT_PRIMARY}="1", ENV{ID_MM_DEVICE_PROCESS}="1"
-ATTRS{idVendor}=="05c6", ATTRS{idProduct}=="908b", ENV{.MM_USBIFNUM}=="02", ENV{ID_MM_PORT_TYPE_AT_SECONDARY}="1", ENV{ID_MM_DEVICE_PROCESS}="1"
+ATTRS{idVendor}=="05c6", ATTRS{idProduct}=="908b", ENV{.MM_USBIFNUM}=="01", ENV{ID_MM_PORT_TYPE_AT_PRIMARY}="1"
+ATTRS{idVendor}=="05c6", ATTRS{idProduct}=="908b", ENV{.MM_USBIFNUM}=="02", ENV{ID_MM_PORT_TYPE_AT_SECONDARY}="1"
ATTRS{idVendor}=="05c6", ATTRS{idProduct}=="908b", ENV{.MM_USBIFNUM}=="03", ENV{ID_MM_PORT_IGNORE}="1"
LABEL="mm_ublox_port_types_end"