diff options
author | Chris Lattner <sabre@nondot.org> | 2009-01-02 07:01:27 +0000 |
---|---|---|
committer | Chris Lattner <sabre@nondot.org> | 2009-01-02 07:01:27 +0000 |
commit | df98617b23315e427cc4fad8ccfdd50d68bec2f9 (patch) | |
tree | 7ff121d47bf96432f608d5059916d6b7062e6d36 /test/Verifier | |
parent | ccb6976a69a6e146db049fff8e6338e31c91b6f8 (diff) |
Reimplement the old and horrible bison parser for .ll files with a nice
and clean recursive descent parser.
This change has a couple of ramifications:
1. The parser code is about 400 lines shorter (in what we maintain, not
including what is autogenerated).
2. The code should be significantly faster than the old code because we
don't have to work around bison's poor handling of datatypes with
ctors/dtors. This also makes the code much more resistant to memory
leaks.
3. We now get caret diagnostics from the .ll parser, woo.
4. The actual diagnostics emited from the parser are completely different
so a bunch of testcases had to be updated.
5. I now disallow "%ty = type opaque %ty = type i32". There was no good
reason to support this, it was just an accident of the old
implementation. I have no reason to think that anyone is actually using
this.
6. The syntax for sticking a global variable has changed to make it
unambiguous. I don't think anyone is depending on this since only clang
supports this and it is not solid yet, so I'm not worried about anything
breaking.
7. This gets rid of the last use of bison, and along with it the .cvs files.
I'll prune this from the makefiles as a subsequent commit.
There are a few minor cleanups that can be done after this commit (suggestions
welcome!) but this passes dejagnu testing and is ready for its time in the
limelight.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@61558 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'test/Verifier')
-rw-r--r-- | test/Verifier/2002-11-05-GetelementptrPointers.ll | 2 | ||||
-rw-r--r-- | test/Verifier/2005-03-21-UndefinedTypeReference.ll | 2 | ||||
-rw-r--r-- | test/Verifier/2006-10-15-AddrLabel.ll | 3 |
3 files changed, 3 insertions, 4 deletions
diff --git a/test/Verifier/2002-11-05-GetelementptrPointers.ll b/test/Verifier/2002-11-05-GetelementptrPointers.ll index e37a0ffd324..1f71387ab3a 100644 --- a/test/Verifier/2002-11-05-GetelementptrPointers.ll +++ b/test/Verifier/2002-11-05-GetelementptrPointers.ll @@ -1,4 +1,4 @@ -; RUN: not llvm-as < %s |& grep {Invalid getelementptr indices} +; RUN: not llvm-as < %s |& grep {invalid getelementptr indices} ; This testcase is invalid because we are indexing into a pointer that is ; contained WITHIN a structure. diff --git a/test/Verifier/2005-03-21-UndefinedTypeReference.ll b/test/Verifier/2005-03-21-UndefinedTypeReference.ll index 19a9826ea52..5299397ab06 100644 --- a/test/Verifier/2005-03-21-UndefinedTypeReference.ll +++ b/test/Verifier/2005-03-21-UndefinedTypeReference.ll @@ -1,4 +1,4 @@ -; RUN: not llvm-as < %s |& grep {Reference to an undefined type} +; RUN: not llvm-as < %s |& grep {use of undefined type named 'InvalidType'} define void @test() { malloc %InvalidType diff --git a/test/Verifier/2006-10-15-AddrLabel.ll b/test/Verifier/2006-10-15-AddrLabel.ll index e2c0e603c33..73b69024c77 100644 --- a/test/Verifier/2006-10-15-AddrLabel.ll +++ b/test/Verifier/2006-10-15-AddrLabel.ll @@ -1,5 +1,4 @@ -; RUN: not llvm-as < %s > /dev/null |& \ -; RUN: grep {Cannot form a pointer to a basic block} +; RUN: not llvm-as < %s > /dev/null |& grep {basic block pointers are invalid} define i32 @main() { %foo = call i8* %llvm.stacksave() |