From a6c4ea315053dc20ced08f9e0f9efb545e2179b7 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Wed, 26 Jun 2013 18:21:22 +0000 Subject: Add a TODO note. Patch by: Aaron Watry git-svn-id: https://llvm.org/svn/llvm-project/libclc/trunk@184998 91177308-0d34-0410-b5e6-96231b3b80d8 --- generic/lib/integer/rotate.inc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/generic/lib/integer/rotate.inc b/generic/lib/integer/rotate.inc index 7792a97..b34ffed 100644 --- a/generic/lib/integer/rotate.inc +++ b/generic/lib/integer/rotate.inc @@ -21,6 +21,10 @@ _CLC_OVERLOAD _CLC_DEF GENTYPE rotate(GENTYPE x, GENTYPE n){ return ( (((UGENTYPE)x) >> -n) | (x << (GENSIZE + n)) ); } #else + //XXX: There's a lot of __builtin_astype calls to cast everything to + // unsigned ... This should be improved so that if GENTYPE==UGENTYPE, no + // casts are required. + UGENTYPE x_1 = __builtin_astype(x, UGENTYPE); UGENTYPE amt; -- cgit v1.2.3