summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristophe Fergeau <cfergeau@redhat.com>2016-06-28 16:46:04 +0200
committerFabiano FidĂȘncio <fidencio@redhat.com>2016-06-29 02:00:09 +0200
commit937693a73a06b1298d21041d6688eaf0087824f6 (patch)
treed0f35042e72704cd608fddf46c5f60501d73ae24
parent612f4ffd2f2a107fe774ca02400310e9bd0a8208 (diff)
window: Don't take a reference on 'toolbar'
VirtViewerTimedRevealer now derives from GtkEventBox/GtkContainer, so it follows GTK+ conventions and takes ownership of the floating ref on 'toolbar'. Since VirtViewerWindow and VirtViewerTimedRevealer will have the same lifespan, we don't need to own a reference on toolbar in VirtViewerWindow. Signed-off-by: Christophe Fergeau <cfergeau@redhat.com> Acked-by: Fabiano FidĂȘncio <fidencio@redhat.com>
-rw-r--r--src/virt-viewer-window.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/virt-viewer-window.c b/src/virt-viewer-window.c
index bf48516..503e230 100644
--- a/src/virt-viewer-window.c
+++ b/src/virt-viewer-window.c
@@ -200,7 +200,7 @@ virt_viewer_window_dispose (GObject *object)
priv->subtitle = NULL;
g_value_unset(&priv->accel_setting);
- g_clear_object(&priv->toolbar);
+ priv->toolbar = NULL;
G_OBJECT_CLASS (virt_viewer_window_parent_class)->dispose (object);
}
@@ -1070,7 +1070,7 @@ virt_viewer_window_toolbar_setup(VirtViewerWindow *self)
GtkWidget *overlay;
VirtViewerWindowPrivate *priv = self->priv;
- priv->toolbar = g_object_ref(gtk_toolbar_new());
+ priv->toolbar = gtk_toolbar_new();
gtk_toolbar_set_show_arrow(GTK_TOOLBAR(priv->toolbar), FALSE);
gtk_widget_set_no_show_all(priv->toolbar, TRUE);
gtk_toolbar_set_style(GTK_TOOLBAR(priv->toolbar), GTK_TOOLBAR_BOTH_HORIZ);