diff options
| -rw-r--r-- | glib/gerror.c | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/glib/gerror.c b/glib/gerror.c index 6217aa28b..7b0b02c2f 100644 --- a/glib/gerror.c +++ b/glib/gerror.c @@ -378,6 +378,14 @@ g_error_new_valist (GQuark domain, { GError *error; + /* Historically, GError allowed this (although it was never meant to work), + * and it has significant use in the wild, which g_return_val_if_fail + * would break. It should maybe g_return_val_if_fail in GLib 4. + * (GNOME#660371, GNOME#560482) + */ + g_warn_if_fail (domain != 0); + g_warn_if_fail (format != NULL); + error = g_slice_new (GError); error->domain = domain; @@ -480,6 +488,9 @@ g_error_copy (const GError *error) GError *copy; g_return_val_if_fail (error != NULL, NULL); + /* See g_error_new_valist for why these don't return */ + g_warn_if_fail (error->domain != 0); + g_warn_if_fail (error->message != NULL); copy = g_slice_new (GError); |