summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMika Kuoppala <mika.kuoppala@intel.com>2016-11-07 15:59:10 +0200
committerMika Kuoppala <mika.kuoppala@intel.com>2016-11-11 15:45:26 +0200
commit0abdfb13590da7f042f7e08f49f1d3bef1ea0300 (patch)
tree49ae2389b7542689ce22c1070cb40b6ed9127381
parentbc9e38c1959c5ff41f147722adf3926f451b257b (diff)
drm/i915: Use request retirement as context progress
As hangcheck score was removed, the active decay of score was removed also. This removed feature for hangcheck to detect if the gpu client was accidentally or maliciously causing intermittent hangs. Reinstate the scoring as a per context property, so that if one context starts to act unfavourably, ban it. v2: ban_period_secs as a gate to score check (Chris) Cc: Chris Wilson <chris@chris-wilson.co.uk> Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
-rw-r--r--drivers/gpu/drm/i915/i915_drv.h3
-rw-r--r--drivers/gpu/drm/i915/i915_gem.c44
-rw-r--r--drivers/gpu/drm/i915/i915_gem_request.c4
3 files changed, 37 insertions, 14 deletions
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 1f04b9effea0..a0b7bfa0448e 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -896,6 +896,9 @@ struct i915_ctx_hang_stats {
/* This context is banned to submit more work */
bool banned;
+
+ /* Accumulated score of hangs caused by this context */
+ int ban_score;
};
/* This must match up with the value previously used for execbuf2.rsvd1. */
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 4c8c92aa9456..f67495f6abf5 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -2554,33 +2554,45 @@ err_unlock:
static bool i915_context_is_banned(const struct i915_gem_context *ctx)
{
+ const struct i915_ctx_hang_stats *hs = &ctx->hang_stats;
unsigned long elapsed;
- if (ctx->hang_stats.banned)
+ if (hs->banned)
return true;
- elapsed = get_seconds() - ctx->hang_stats.guilty_ts;
- if (ctx->hang_stats.ban_period_seconds &&
- elapsed <= ctx->hang_stats.ban_period_seconds) {
+ if (!hs->ban_period_seconds)
+ return false;
+
+ elapsed = get_seconds() - hs->guilty_ts;
+ if (elapsed <= hs->ban_period_seconds) {
DRM_DEBUG("context hanging too fast, banning!\n");
return true;
}
+ if (hs->ban_score >= 40) {
+ DRM_DEBUG("context hanging too often, banning!\n");
+ return true;
+ }
+
return false;
}
-static void i915_set_reset_status(struct i915_gem_context *ctx,
- const bool guilty)
+static void i915_gem_context_mark_guilty(struct i915_gem_context *ctx)
{
struct i915_ctx_hang_stats *hs = &ctx->hang_stats;
- if (guilty) {
- hs->banned = i915_context_is_banned(ctx);
- hs->batch_active++;
- hs->guilty_ts = get_seconds();
- } else {
- hs->batch_pending++;
- }
+ hs->ban_score += 10;
+
+ hs->banned = i915_context_is_banned(ctx);
+ hs->batch_active++;
+ hs->guilty_ts = get_seconds();
+}
+
+static void i915_gem_context_mark_innocent(struct i915_gem_context *ctx)
+{
+ struct i915_ctx_hang_stats *hs = &ctx->hang_stats;
+
+ hs->batch_pending++;
}
struct drm_i915_gem_request *
@@ -2648,7 +2660,11 @@ static void i915_gem_reset_engine(struct intel_engine_cs *engine)
ring_hung = false;
}
- i915_set_reset_status(request->ctx, ring_hung);
+ if (ring_hung)
+ i915_gem_context_mark_guilty(request->ctx);
+ else
+ i915_gem_context_mark_innocent(request->ctx);
+
if (!ring_hung)
return;
diff --git a/drivers/gpu/drm/i915/i915_gem_request.c b/drivers/gpu/drm/i915/i915_gem_request.c
index 5050464c5401..de0569c63b4b 100644
--- a/drivers/gpu/drm/i915/i915_gem_request.c
+++ b/drivers/gpu/drm/i915/i915_gem_request.c
@@ -128,6 +128,10 @@ static void i915_gem_request_retire(struct drm_i915_gem_request *request)
trace_i915_gem_request_retire(request);
+ /* Retirement decays the ban score as it is a sign of ctx progress */
+ if (request->ctx->hang_stats.ban_score > 0)
+ request->ctx->hang_stats.ban_score--;
+
spin_lock_irq(&request->engine->timeline->lock);
list_del_init(&request->link);
spin_unlock_irq(&request->engine->timeline->lock);