From d9e99edd4dcf109492abdaa73ccf8f29d5bfd159 Mon Sep 17 00:00:00 2001 From: Adam Jackson Date: Wed, 30 Apr 2014 13:49:06 -0400 Subject: glxproxy: Fix memory leak on error path in CreateGLXPixmap (#50281) (v2) v2: Fix another path spotted by keithp Signed-off-by: Adam Jackson Reviewed-by: Jasper St. Pierre Reviewed-by: Keith Packard Signed-off-by: Keith Packard --- hw/dmx/glxProxy/glxcmds.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/dmx/glxProxy/glxcmds.c b/hw/dmx/glxProxy/glxcmds.c index 964db4069..23c3366bd 100644 --- a/hw/dmx/glxProxy/glxcmds.c +++ b/hw/dmx/glxProxy/glxcmds.c @@ -2009,6 +2009,7 @@ CreateGLXPixmap(__GLXclientState * cl, } else { client->errorValue = (visual ? visual : fbconfigId); + free(pGlxPixmap->be_xids); free(pGlxPixmap); return BadValue; } @@ -2017,6 +2018,7 @@ CreateGLXPixmap(__GLXclientState * cl, } if (!(AddResource(glxpixmapId, __glXPixmapRes, pGlxPixmap))) { + free(pGlxPixmap->be_xids); free(pGlxPixmap); return BadAlloc; } -- cgit v1.2.3