From 0a26e076e10a3c7461d59c830cdc10688d66824f Mon Sep 17 00:00:00 2001 From: Aaron Plattner Date: Wed, 6 Feb 2013 13:08:58 -0800 Subject: Bug #11397: check that numeric --orientation arguments are in range The only valid parameters to -o (--orientation) are 0, 1, 2, 3, normal, left, inverted, and right. xrandr converts the strings to numbers and then checks that they're within range, but doesn't validate them if it was numeric to begin with. Move the range check outside of the if statement so that out-of-range numeric values are rejected properly. Signed-off-by: Aaron Plattner Reviewed-by: Daniel Dadap --- xrandr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xrandr.c b/xrandr.c index b0e8cec..926bc68 100644 --- a/xrandr.c +++ b/xrandr.c @@ -2579,8 +2579,8 @@ main (int argc, char **argv) for (dirind = 0; dirind < 4; dirind++) { if (strcmp (direction[dirind], argv[i]) == 0) break; } - if ((dirind < 0) || (dirind > 3)) usage(); } + if ((dirind < 0) || (dirind > 3)) usage(); rot = dirind; setit = True; action_requested = True; -- cgit v1.2.3