diff options
| author | Erik Faye-Lund <erik.faye-lund@collabora.com> | 2019-04-09 14:25:51 +0200 |
|---|---|---|
| committer | Erik Faye-Lund <erik.faye-lund@collabora.com> | 2019-04-17 07:27:08 +0000 |
| commit | ce1761edabf8c27f3e76d6790b0876930ef390dc (patch) | |
| tree | ef7019106a69d6c9717d3e60dca43fd9adb33acf | |
| parent | 3fdacf1c390b5281c9adb4fbfdacd2757023941c (diff) | |
virgl: document potentially failing blit
This blit can fail, but this is not new; in the old version we
didn't even try to blit in this case. So let's just document the
limitation for now, and leave this for another day.
Signed-off-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
| -rw-r--r-- | src/gallium/drivers/virgl/virgl_texture.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/src/gallium/drivers/virgl/virgl_texture.c b/src/gallium/drivers/virgl/virgl_texture.c index bbda3f2406e..f0a2465021c 100644 --- a/src/gallium/drivers/virgl/virgl_texture.c +++ b/src/gallium/drivers/virgl/virgl_texture.c @@ -298,6 +298,12 @@ static void virgl_texture_transfer_unmap(struct pipe_context *ctx, flush_data(ctx, virgl_transfer(trans->resolve_transfer), &trans->resolve_transfer->box); + /* FINISHME: In case the destination format isn't renderable here, the + * blit here will currently fail. This could for instance happen if the + * mapped resource is of a compressed format, and it's mapped with both + * read and write usage. + */ + virgl_copy_region_with_blit(ctx, trans->base.resource, trans->base.level, &transfer->box, |