summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChris Wilson <chris@chris-wilson.co.uk>2011-06-10 16:14:49 +0100
committerChris Wilson <chris@chris-wilson.co.uk>2011-08-25 11:57:19 +0100
commit5d791002974963c334993fc53ed6a5168a590ffb (patch)
tree3001e8a449220645af0a65d7a7d8b87cd63c8e4e
parente32cc0b4c85c78cd8743a6e1680dcc79054b57ce (diff)
composite: don't update the ScreenPixmap->serialNumber window motion
dri2 uses the pixmap->serialNumber as a unique identifier that is constant for the lifetime of the pixmap. (So it can detect the change of framebuffer for example.) This appears to be the only interpretation of pixmap->serialNumber by all the other consumers. The result was that pageflipping was causing the DRI2 buffers to be revoked, resulting in a massive increase in aperture thrashing - the exact opposite of what pageflipping is supposed to achieve - under a composting window manager. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Ville Syrjälä <ville.syrjala@nokia.com> Cc: Dave Airlie <airlied@redhat.com> Cc: Kristian Høgsberg <krh@bitplanet.net> Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
-rw-r--r--composite/compwindow.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/composite/compwindow.c b/composite/compwindow.c
index d2a866d6f..461028d81 100644
--- a/composite/compwindow.c
+++ b/composite/compwindow.c
@@ -242,7 +242,6 @@ compPositionWindow (WindowPtr pWin, int x, int y)
{
pPixmap->screen_x = nx;
pPixmap->screen_y = ny;
- pPixmap->drawable.serialNumber = NEXT_SERIAL_NUMBER;
}
}