summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJason Gunthorpe <jgg@mellanox.com>2019-05-22 19:51:55 +0000
committerJérôme Glisse <jglisse@redhat.com>2019-05-23 17:09:26 -0400
commitc64485ea451281fc551fc22657d584f789c7270c (patch)
tree7c572b0035eda8f410943207b6ee8ce154cbdc54
parenta77832e5758a3d0d692d0f0a0243b630490d5858 (diff)
hmm: Suppress compilation warnings when CONFIG_HUGETLB_PAGE is not sethmm-5.3
gcc reports that several variables are defined but not used. For the first hunk CONFIG_HUGETLB_PAGE the entire if block is already protected by pud_huge() which is forced to 0. None of the stuff under the ifdef causes compilation problems as it is already stubbed out in the header files. For the second hunk the dummy huge_page_shift macro doesn't touch the argument, so just inline the argument. Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
-rw-r--r--mm/hmm.c9
1 files changed, 2 insertions, 7 deletions
diff --git a/mm/hmm.c b/mm/hmm.c
index fca05c378404..836adf613f81 100644
--- a/mm/hmm.c
+++ b/mm/hmm.c
@@ -768,7 +768,6 @@ again:
return hmm_vma_walk_hole_(addr, end, fault,
write_fault, walk);
-#ifdef CONFIG_HUGETLB_PAGE
pfn = pud_pfn(pud) + ((addr & ~PUD_MASK) >> PAGE_SHIFT);
for (i = 0; i < npages; ++i, ++pfn) {
hmm_vma_walk->pgmap = get_dev_pagemap(pfn,
@@ -784,9 +783,6 @@ again:
}
hmm_vma_walk->last = end;
return 0;
-#else
- return -EINVAL;
-#endif
}
split_huge_pud(walk->vma, pudp, addr);
@@ -1005,9 +1001,8 @@ long hmm_range_snapshot(struct hmm_range *range)
return -EFAULT;
if (is_vm_hugetlb_page(vma)) {
- struct hstate *h = hstate_vma(vma);
-
- if (huge_page_shift(h) != range->page_shift &&
+ if (huge_page_shift(hstate_vma(vma)) !=
+ range->page_shift &&
range->page_shift != PAGE_SHIFT)
return -EINVAL;
} else {