summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2019-07-26Add a test for optionsFrediano Ziglio4-1/+100
Signed-off-by: Frediano Ziglio <fziglio@redhat.com> Acked-by: Jeremy White <jwhite@codeweavers.com>
2019-07-26Removed only written system_config_file fieldFrediano Ziglio2-3/+1
Signed-off-by: Frediano Ziglio <fziglio@redhat.com> Acked-by: Jeremy White <jwhite@codeweavers.com>
2019-07-26Bug fix: a listen specification from the config file was ignoredJeremy White1-1/+3
Signed-off-by: Jeremy White <jwhite@codeweavers.com> Acked-by: Frediano Ziglio <fziglio@redhat.com>
2019-07-26Simplify the expression of argument parsing.Jeremy White3-39/+25
This fixes a bug with --config=handling. Removed old testing code as obsolete instead of updating unused code. Signed-off-by: Jeremy White <jwhite@codeweavers.com> Acked-by: Frediano Ziglio <fziglio@redhat.com>
2019-07-26Simplify string options and make sure they are freed when replaced.Jeremy White1-64/+54
This is largely the work of Frediano Ziglio <fziglio@redhat.com>. Signed-off-by: Jeremy White <jwhite@codeweavers.com> Acked-by: Frediano Ziglio <fziglio@redhat.com>
2019-07-24Fix a bug in the tests.Jeremy White1-4/+11
We were overly dependent on timing for success; now we deliberately wait for our GC and drawing to finish. Signed-off-by: Jeremy White <jwhite@codeweavers.com> Acked-by: Frediano Ziglio <fziglio@redhat.com>
2019-07-24Use C99 struct initializiers instead of memset for local structures.Jeremy White4-9/+4
Signed-off-by: Jeremy White <jwhite@codeweavers.com> Acked-by: Frediano Ziglio <fziglio@redhat.com>
2019-07-23Free the SSL and password_file option fields.Jeremy White1-0/+15
Signed-off-by: Jeremy White <jwhite@codeweavers.com> Acked-by: Frediano Ziglio <fziglio@redhat.com>
2019-07-23Convert to the use of glib memory routines in options.c.Jeremy White1-26/+20
Signed-off-by: Jeremy White <jwhite@codeweavers.com> Acked-by: Frediano Ziglio <fziglio@redhat.com>
2019-07-15Fix hang when launching with invalid configBrendan Shanks1-0/+2
When launching with no config file or arguments, the "You must provide some authentication method" dialog appears. Clicking the Close button would hang the application and it would never quit. s->draw_command_in_progress was uninitialized, and flush_and_lock() would get stuck in an infinite loop waiting for it to be 0. Initialize the entire session struct to 0. Signed-off-by: Brendan Shanks <bshanks@codeweavers.com> Acked-by: Frediano Ziglio <fziglio@redhat.com>
2019-07-12Fix segfault when quitting with Quit buttonBrendan Shanks1-1/+1
Quitting with the Quit button or closing the window always causes a segfault for me. Destroying the surface before removing the interface seems to resolve the problem. log from valgrind: ==7741== Invalid read of size 8 ==7741== at 0x6943517: red_qxl_destroy_primary_surface_sync (red-qxl.c:313) ==7741== by 0x6943517: red_qxl_destroy_primary_surface (red-qxl.c:338) ==7741== by 0x6943517: spice_qxl_destroy_primary_surface (red-qxl.c:696) ==7741== by 0x111F60: spice_destroy_primary (spice.c:506) ==7741== by 0x111F60: spice_end (spice.c:694) ==7741== by 0x10CBDA: main (main.c:154) ==7741== Address 0x88 is not stack'd, malloc'd or (recently) free'd ==7741== ==7741== ==7741== Process terminating with default action of signal 11 (SIGSEGV) ==7741== Access not within mapped region at address 0x88 ==7741== at 0x6943517: red_qxl_destroy_primary_surface_sync (red-qxl.c:313) ==7741== by 0x6943517: red_qxl_destroy_primary_surface (red-qxl.c:338) ==7741== by 0x6943517: spice_qxl_destroy_primary_surface (red-qxl.c:696) ==7741== by 0x111F60: spice_destroy_primary (spice.c:506) ==7741== by 0x111F60: spice_end (spice.c:694) ==7741== by 0x10CBDA: main (main.c:154) Signed-off-by: Brendan Shanks <bshanks@codeweavers.com> Acked-by: Frediano Ziglio <fziglio@redhat.com>
2019-06-19Changes to build on the 32 bit raspberry pi.Jeremy White3-14/+18
Signed-off-by: Jeremy White <jwhite@codeweavers.com> Acked-by: Frediano Ziglio <fziglio@redhat.com>
2019-05-03Spelling.Henri Verbeet1-1/+1
2019-05-03Add a --enable-dummy option to configure.Jeremy White4-0/+59
Provide some basic documentation as to how to use the new spice-video-dummy driver.
2019-05-03Initial set of revisions to the dummy driver to add DRI and Present.Jeremy White9-31/+565
This makes the dummy driver similar to the mode setting driver. This work was done by Henri Verbeet, which was in turn based heavily on the Xorg modesetting driver.
2019-05-03Apply Spice style to the spice-video-dummyJeremy White4-289/+309
Do this using the spice_indent script which uses indent to apply current Spice styles (as per Frediano Ziglio on 2019-05-01). This also includes a fixup from Frediano which provides braces around all ifs and removes extra parens from returns.
2019-05-03Add the upstream xf86-video-dummy as of November 25, 2018.Jeremy White10-0/+1181
This gives x11spice access to a modern virtual/offscreen frame buffer driver for the Xorg X server. We will then make slight revisions to make it more suitable for use with Spice. The overall result should be a more functional stack, as compared to the existing xf86-video-qxl driver, as we gain a wide range of Mesa features for free. It also simplifies the overall process. This is from https://gitlab.freedesktop.org/xorg/driver/xf86-video-dummy as of 850c0516.
2018-02-05Merge branch 'master' into 'master'Jeremy White2-3/+2
Fix build on Ubuntu 16.04 See merge request spice/x11spice!1
2018-02-04Fix -Wformat-security errorSam Protsenko1-1/+1
As -Werror flag is used in src/Makefile.am, next error occurs: gui.c: In function ‘gui_report_error’: gui.c:134:17: error: format not a string literal and no format arguments [-Werror=format-security] message); Disable -Wformat-security in order to fix the build, before the code is actually fixed. Signed-off-by: Sam Protsenko <joe.skb7@gmail.com>
2018-02-04tests: Fix incorrect order of linker flagsSam Protsenko1-2/+1
Libraries flags (like -lglib-2.0) should be provided in the end of compile command. It's not how it's done right now in tests/Makefile.am, because _LDFLAGS is used where we should actually use _LDADD. Due to this, on Ubuntu 16.04 with GCC 5 we have next linking errors: gcc -lxcb-damage -lxcb-xfixes -lxcb-render -lxcb-shape -lxcb -lxcb-xtest -lxcb -lxcb-shm -lxcb -lxcb-util -lxcb -lgtk-x11-2.0 -lgdk-x11-2.0 -lpangocairo-1.0 -latk-1.0 -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lpangoft2-1.0 -lpango-1.0 -lgobject-2.0 -lglib-2.0 -lfontconfig -lfreetype -lspice-server -lglib-2.0 -lpixman-1 -o x11spice_test tests.o x11spice_test.o xcb.o xdummy.o util.o main.o -laudit tests.o: In function `check_binary': src/tests/tests.c:83: undefined reference to `g_log' src/tests/tests.c:84: undefined reference to `g_test_skip' tests.o: In function `test_common_start': src/tests/tests.c:46: undefined reference to `g_test_build_filename' src/tests/tests.c:56: undefined reference to `g_log' src/tests/tests.c:57: undefined reference to `g_test_fail' src/tests/tests.c:39: undefined reference to `g_test_skip' src/tests/tests.c:48: undefined reference to `g_log' src/tests/tests.c:49: undefined reference to `g_test_fail' Use _LDADD instead of _LDFLAGS for libs, so that libraries are specified in the end of compile line. Signed-off-by: Sam Protsenko <joe.skb7@gmail.com>
2017-01-16Merge pull request #2 from xerus/masterJeremy White13-36/+46
Make it compile on the latest Fedora
2017-01-13Allow to compile with gtk3Pavel Grunt3-5/+6
2017-01-13Fix compile warningsPavel Grunt10-31/+38
Mostly unused parameters, make it compile with gcc version 6.3.1
2017-01-13Include header for SPICE_CONTAINEROFPavel Grunt2-0/+2
2016-12-08Adding missing libaudit ifdefsSnir Sheriber1-0/+4
2016-11-03Use an atexit() register to ensure that we catch disconnections.Jeremy White1-0/+10
If we are using the exit-on-disconnect feature, there may be an exit() prior to the disconnect callback. This ensures that the disconnect callback and audit functions fire even in that case.
2016-11-02Prepare for a version 1.1 release.Jeremy White5-4/+28
Also add a target to create an rpm.
2016-11-02Add sample connection scripts for Gnome.Jeremy White4-2/+66
These scripts save the current desktop background, and then turn it red while a connection is active.
2016-11-01Allow a command line override of the allow-control config choice.Jeremy White1-1/+8
2016-10-31Add an option to require auditing.Jeremy White7-0/+94
2016-10-31Add the ability to specify connect and disconnect callbacks.Jeremy White7-18/+132
These scripts enable a user to do some action (such as changing screen background color) upon connect and disconnect.
2016-10-27Invert the logic of viewonly.Jeremy White6-17/+16
This makes view only the default, and requires an explicit request to allow-control instead.
2016-10-10Protect against a memory allocation failure; for Coverity.Jeremy White1-0/+3
2016-09-21Ensure that the damage thread is shut down cleanly.Jeremy White3-0/+10
2016-09-21Fix a copy-paste bug in an obscure and hard to trigger guard line.Jeremy White1-1/+1
(Found by Coverity)
2016-09-21Clarify code check usage.Jeremy White1-2/+3
2016-09-19Create the scanner before the display thread.Jeremy White1-4/+4
Avoids a potential race condition error.
2016-09-13Give the user a hint if they do not provide any password.Jeremy White5-0/+41
2016-09-12Revise to add an explicit requirement on a later libxcb-devel library.Jeremy White1-1/+2
2016-09-02Fix another warning.Jeremy White1-1/+1
Signed-off-by: Jeremy White <jwhite@codeweavers.com>
2016-09-02Add an icon, desktop file, and spec file to support packaging.Jeremy White6-4/+64
This gets us an rpm. Signed-off-by: Jeremy White <jwhite@codeweavers.com>
2016-09-02Catch a warning on rhel 6.Jeremy White1-1/+1
Signed-off-by: Jeremy White <jwhite@codeweavers.com>
2016-09-02Add support for SSL.Jeremy White5-2/+142
2016-09-02Remove debug information on mm_time; it's distracting.Jeremy White1-1/+2
Signed-off-by: Jeremy White <jwhite@codeweavers.com>
2016-09-02Older versions of glib require us to start threads.Jeremy White1-0/+4
Signed-off-by: Jeremy White <jwhite@codeweavers.com>
2016-09-02Older versions of spice rely on a negative stride.Jeremy White1-2/+1
Signed-off-by: Jeremy White <jwhite@codeweavers.com>
2016-09-02Review all remaining FIXME messages.Jeremy White6-27/+26
Switch to TODO (Spice standard) where appropriate, remove elsewhere.
2016-09-02Enable building and compilation on RHEL 6.Jeremy White10-40/+71
This involves handling older glib, older gcc, and accomodating a lack of the the autoconf macros for gconf. Signed-off-by: Jeremy White <jwhite@codeweavers.com>
2016-08-31Needed to sleep just a bit longer.Jeremy White1-1/+1
2016-08-31Reduce log messages that are not really desirable in production.Jeremy White1-0/+7
generated by cgit v1.2.3 (git 2.39.1) at 2025-09-09 02:41:32 +0000