summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVinson Lee <vlee@freedesktop.org>2015-01-09 17:41:57 -0800
committerVinson Lee <vlee@freedesktop.org>2015-01-10 15:50:37 -0800
commit59852af1328c784ea7148dd4544d06602ca9c28b (patch)
treed944980aa2ba419f6da81094f0b55f5942481129
parentca4630fd64926cac10a8b26c09500c35a733261e (diff)
arb_direct_state_access: Fix memory leak.
Fix resource leak defect reported by Coverity. Also move piglit_rgbw_image_ubyte call outside of loop as suggested by Brian Paul. Signed-off-by: Vinson Lee <vlee@freedesktop.org> Reviewed-by: Brian Paul <brianp@vmware.com>
-rw-r--r--tests/spec/arb_direct_state_access/getcompressedtextureimage.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/tests/spec/arb_direct_state_access/getcompressedtextureimage.c b/tests/spec/arb_direct_state_access/getcompressedtextureimage.c
index 734ef72f6..9546af599 100644
--- a/tests/spec/arb_direct_state_access/getcompressedtextureimage.c
+++ b/tests/spec/arb_direct_state_access/getcompressedtextureimage.c
@@ -96,13 +96,15 @@ make_layer_data(int num_layers)
int z;
GLubyte *layer_data =
malloc(num_layers * IMAGE_SIZE * sizeof(GLubyte));
+ GLubyte *data = piglit_rgbw_image_ubyte(IMAGE_WIDTH,
+ IMAGE_HEIGHT, true);
for (z = 0; z < num_layers; z++) {
- GLubyte *data = piglit_rgbw_image_ubyte(IMAGE_WIDTH,
- IMAGE_HEIGHT, true);
memcpy(layer_data + IMAGE_SIZE * z, data, IMAGE_SIZE);
}
+ free(data);
+
/* Show the first layer of the completed layer data. */
show_image(layer_data, num_layers, "Test Data");