From c2994001680a7dcf9c167886d49b7326c97cd5d1 Mon Sep 17 00:00:00 2001 From: Aaron Plattner Date: Fri, 21 Nov 2014 08:39:02 -0800 Subject: os: "Server terminated successfully" is not an error ErrorFSigSafe calls LogVMessageVerbSigSafe with the message type set to X_ERROR. That generates this in the log: (EE) Server terminated successfully (0). Closing log file. People periodically report this as an error, sometimes quoting this "error" rather than an earlier error that actually caused a problem. v2: Use X_INFO instead of X_NOTICE Signed-off-by: Aaron Plattner Reviewed-by: Keith Packard Reviewed-by: Eric Anholt Signed-off-by: Keith Packard --- os/log.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'os') diff --git a/os/log.c b/os/log.c index 2e3b3f61f..0532c2eb7 100644 --- a/os/log.c +++ b/os/log.c @@ -257,8 +257,11 @@ void LogClose(enum ExitCode error) { if (logFile) { - ErrorFSigSafe("Server terminated %s (%d). Closing log file.\n", - (error == EXIT_NO_ERROR) ? "successfully" : "with error", error); + int msgtype = (error == EXIT_NO_ERROR) ? X_INFO : X_ERROR; + LogMessageVerbSigSafe(msgtype, -1, + "Server terminated %s (%d). Closing log file.\n", + (error == EXIT_NO_ERROR) ? "successfully" : "with error", + error); fclose(logFile); logFile = NULL; logFileFd = -1; -- cgit v1.2.3