diff options
authorChristian Gmeiner <>2017-06-09 12:27:34 +0200
committerHawking Zhang <>2017-07-31 16:19:54 +0800
commit4bb5a6c29dd940f2c2c9a3f2eb14f488f043dcf3 (patch)
parente8ad2432e1d329be1589c4fe072e3cf38e1b97a0 (diff)
etnaviv: submit full struct drm_etnaviv_gem_submit
It is safe to submit the full struct even on older kernels as such kernels do not process the full struct. Without this change it becomes quite challenging to extned the submit struct. Freedreno has no special treatment too. See git commits - freedreno: sync uapi header - freedreno: add fence fd support Signed-off-by: Christian Gmeiner <> Reviewed-by: Philipp Zabel <> Tested-by: Philipp Zabel <>
1 files changed, 1 insertions, 7 deletions
diff --git a/etnaviv/etnaviv_cmd_stream.c b/etnaviv/etnaviv_cmd_stream.c
index 3c7b0ed6..8d0e8135 100644
--- a/etnaviv/etnaviv_cmd_stream.c
+++ b/etnaviv/etnaviv_cmd_stream.c
@@ -203,14 +203,8 @@ static void flush(struct etna_cmd_stream *stream, int in_fence_fd,
if (out_fence_fd)
- /*
- * Pass the complete submit structure only if flags are set. Otherwise,
- * only pass the fields up to, but not including the flags field for
- * backwards compatiblity with older kernels.
- */
ret = drmCommandWriteRead(gpu->dev->fd, DRM_ETNAVIV_GEM_SUBMIT,
- &req, req.flags ? sizeof(req) :
- offsetof(struct drm_etnaviv_gem_submit, flags));
+ &req, sizeof(req));
if (ret)
ERROR_MSG("submit failed: %d (%s)", ret, strerror(errno));