From 17d30369f4445e1693a1b75dc6620bbc21ec8e61 Mon Sep 17 00:00:00 2001 From: Michel Dänzer Date: Wed, 14 Mar 2018 16:48:23 +0100 Subject: randr: Initialize RROuptutRec::nonDesktop MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Flagged by valgrind: ==13695== Conditional jump or move depends on uninitialised value(s) ==13695== at 0x22461C: RRNoticePropertyChange (rrproperty.c:150) ==13695== by 0x22461C: RRChangeOutputProperty (rrproperty.c:263) ==13695== by 0x222FC4: RROutputSetNonDesktop (rroutput.c:333) ==13695== by 0x22319C: RROutputCreate (rroutput.c:122) ==13695== by 0x1E1CE9: xf86RandR12CreateObjects12 (xf86RandR12.c:1734) ==13695== by 0x1E1CE9: xf86RandR12Init12 (xf86RandR12.c:2375) ==13695== by 0x1E1CE9: xf86RandR12Init (xf86RandR12.c:895) ==13695== by 0x1D469B: xf86CrtcScreenInit (xf86Crtc.c:778) ==13695== by 0xC095A54: RADEONScreenInit_KMS (radeon_kms.c:2436) ==13695== by 0x161444: AddGPUScreen (dispatch.c:3966) ==13695== by 0x1A3E46: InitOutput (xf86Init.c:763) ==13695== by 0x1654A7: dix_main (main.c:193) ==13695== by 0x7041A86: (below main) (libc-start.c:310) ==13695== Uninitialised value was created by a heap allocation ==13695== at 0x4C2CB8F: malloc (vg_replace_malloc.c:299) ==13695== by 0x223083: RROutputCreate (rroutput.c:83) ==13695== by 0x1E1CE9: xf86RandR12CreateObjects12 (xf86RandR12.c:1734) ==13695== by 0x1E1CE9: xf86RandR12Init12 (xf86RandR12.c:2375) ==13695== by 0x1E1CE9: xf86RandR12Init (xf86RandR12.c:895) ==13695== by 0x1D469B: xf86CrtcScreenInit (xf86Crtc.c:778) ==13695== by 0xC095A54: RADEONScreenInit_KMS (radeon_kms.c:2436) ==13695== by 0x161444: AddGPUScreen (dispatch.c:3966) ==13695== by 0x1A3E46: InitOutput (xf86Init.c:763) ==13695== by 0x1654A7: dix_main (main.c:193) ==13695== by 0x7041A86: (below main) (libc-start.c:310) Signed-off-by: Michel Dänzer Reviewed-by: Keith Packard Signed-off-by: Keith Packard --- randr/rroutput.c | 1 + 1 file changed, 1 insertion(+) (limited to 'randr') diff --git a/randr/rroutput.c b/randr/rroutput.c index b0ffedea8..33300e1cc 100644 --- a/randr/rroutput.c +++ b/randr/rroutput.c @@ -106,6 +106,7 @@ RROutputCreate(ScreenPtr pScreen, output->properties = NULL; output->pendingProperties = FALSE; output->changed = FALSE; + output->nonDesktop = FALSE; output->devPrivate = devPrivate; if (!AddResource(output->id, RROutputType, (void *) output)) -- cgit v1.2.3