diff options
| author | Adam Jackson <ajax@redhat.com> | 2014-05-22 13:58:45 -0400 |
|---|---|---|
| committer | Adam Jackson <ajax@redhat.com> | 2014-07-29 09:51:48 -0400 |
| commit | d5b279977236c4f80a8ba81db1f81a314484facf (patch) | |
| tree | 4ee57665f84cfc576e11d7676b7e1a3e3f8373e7 /miext | |
| parent | cf4793d99ecee4dfd6094e02b1ccb89eb744d313 (diff) | |
miext/shadow: Remove shadowInit
This code is nonsensical. You end up creating a screen-sized pixmap
that's totally detached from everything else, which you then listen for
damage on, which means you'll never hear any damage, which means your
shadow update hooks will never get called. Any driver using this would
be sorely disappointed.
Reviewed-by: Keith Packard <keithp@keithp.com>
Signed-off-by: Adam Jackson <ajax@redhat.com>
Diffstat (limited to 'miext')
| -rw-r--r-- | miext/shadow/shadow.c | 20 | ||||
| -rw-r--r-- | miext/shadow/shadow.h | 4 |
2 files changed, 0 insertions, 24 deletions
diff --git a/miext/shadow/shadow.c b/miext/shadow/shadow.c index 6690f7047..0dd3604a7 100644 --- a/miext/shadow/shadow.c +++ b/miext/shadow/shadow.c @@ -196,23 +196,3 @@ shadowRemove(ScreenPtr pScreen, PixmapPtr pPixmap) RemoveBlockAndWakeupHandlers(shadowBlockHandler, shadowWakeupHandler, (void *) pScreen); } - -Bool -shadowInit(ScreenPtr pScreen, ShadowUpdateProc update, ShadowWindowProc window) -{ - PixmapPtr pPixmap; - - pPixmap = pScreen->CreatePixmap(pScreen, pScreen->width, pScreen->height, - pScreen->rootDepth, 0); - if (!pPixmap) - return FALSE; - - if (!shadowSetup(pScreen)) { - pScreen->DestroyPixmap(pPixmap); - return FALSE; - } - - shadowAdd(pScreen, pPixmap, update, window, SHADOW_ROTATE_0, 0); - - return TRUE; -} diff --git a/miext/shadow/shadow.h b/miext/shadow/shadow.h index 9c5f991f8..86fa94479 100644 --- a/miext/shadow/shadow.h +++ b/miext/shadow/shadow.h @@ -87,10 +87,6 @@ shadowAdd(ScreenPtr pScreen, extern _X_EXPORT void shadowRemove(ScreenPtr pScreen, PixmapPtr pPixmap); -extern _X_EXPORT Bool - -shadowInit(ScreenPtr pScreen, ShadowUpdateProc update, ShadowWindowProc window); - extern _X_EXPORT void *shadowAlloc(int width, int height, int bpp); extern _X_EXPORT void |