path: root/hw/xfree86/x86emu
diff options
authorPeter Harris <>2019-11-14 14:06:21 -0500
committerPeter Harris <>2020-02-25 12:12:55 -0500
commitde940e06f8733d87bbb857aef85d830053442cfe (patch)
tree44618156926de2e6973ead298647a1bbb65402f0 /hw/xfree86/x86emu
parent270e439739e023463e7e0719a4eede69d45f7a3f (diff)
xkb: fix key type index check in _XkbSetMapChecks
This code block was moved from a function that returns 0 for failure to a function that returns 0 for Success in commit 649293f6b634e6305b6737a841d6e9d0f0065d6c. Change the return value to BadValue to match the other checks in _XkbSetMapChecks. Set nTypes to xkb->map->num_types when XkbKeyTypesMask is not set, to allow requests with the XkbKeyTypesMask flag unset in stuff->present to succeed. Fixes a potential heap smash when client->swapped is true, because the remainder of the request will not be swapped after "return 0", but _XkbSetMap will be called anyway (because 0 is Success). Signed-off-by: Peter Harris <>
Diffstat (limited to 'hw/xfree86/x86emu')
0 files changed, 0 insertions, 0 deletions