diff options
authorKristian Høgsberg <>2010-10-28 20:46:23 -0700
committerJeremy Huddleston <>2010-11-13 15:25:28 -0800
commita0895a219027e0a52a5a02db903d662562e02dda (patch)
parentdfda3c696dd72ecc5cc4fa69d8bb4521ba554cf3 (diff)
Set DamageSetReportAfterOp to true for the damage extension
Change the damage extension reporter to queue up events after we chain to the wrapped functions. Damage events are typically sent out after the rendering happens anyway, since we submit batch buffers from the flush callback chain and then flush client io buffers. Compositing managers relie on this order, and there is no way we could reliably provide damage events to clients before the rendering happens anyway. By queueing up the damage events before the rendering happens, there's a risk that the client io buffer may overflow and send the damage events to the client before the driver has even seen the rendering request. Reporting damage events after the rendering fixes this corner case and better corresponds with how we expect this to work. Signed-off-by: Kristian Høgsberg <> Reviewed-by: Keith Packard <> (cherry picked from commit 8d7b7a0d71e0b89321b3341b781bc8845386def6) [anholt: re-applied to revert the revert, now that the cause of the revert is fixed] Signed-off-by: Keith Packard <> (cherry picked from commit 333b6ed26e36735ef72f314a3f8c4ec565af223f)
1 files changed, 1 insertions, 0 deletions
diff --git a/damageext/damageext.c b/damageext/damageext.c
index 4aa0ff3a1..754383d49 100644
--- a/damageext/damageext.c
+++ b/damageext/damageext.c
@@ -217,6 +217,7 @@ ProcDamageCreate (ClientPtr client)
if (!AddResource (stuff->damage, DamageExtType, (pointer) pDamageExt))
return BadAlloc;
+ DamageSetReportAfterOp (pDamageExt->pDamage, TRUE);
DamageRegister (pDamageExt->pDrawable, pDamageExt->pDamage);
if (pDrawable->type == DRAWABLE_WINDOW)