summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2024-02-17unifdef LynxHEADmasterAlan Coopersmith1-5/+0
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2024-02-04libXvMC 1.0.14libXvMC-1.0.14Alan Coopersmith2-3/+3
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2023-03-19Handle implicit conversion warnings from clangAlan Coopersmith2-44/+43
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2023-03-19Replace custom copy of GetReq macro with call to Xlib 1.5's _XGetRequestAlan Coopersmith1-9/+5
XvMCproto.h names don't match those required by the Xlibint.h GetReq* macros, but at least we can rely on the _XGetRequest function for the bulk of the work now, instead of duplicating it. Continues to use sizeof() instead of SIZEOF() due to stray ; on the end of many sz_* definitions in XvMCproto.h, but I've verified the sizes are the same with both methods. Also clears clang warnings that were repeated for every call: XvMC.c:79:5: warning: cast from 'char *' to 'xvmcQueryVersionReq *' increases required alignment from 1 to 2 [-Wcast-align] XvMCGetReq(QueryVersion, req); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ./XvMClibint.h:16:8: note: expanded from macro 'XvMCGetReq' req = (xvmc##name##Req *)(dpy->last_req = dpy->bufptr);\ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ XvMC.c:79:5: warning: implicit conversion loses integer precision: 'int' to 'CARD8' (aka 'unsigned char') [-Wconversion] XvMCGetReq(QueryVersion, req); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ./XvMClibint.h:17:30: note: expanded from macro 'XvMCGetReq' req->reqType = info->codes->major_opcode;\ ~ ~~~~~~~~~~~~~^~~~~~~~~~~~ Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2023-03-19Variable scope reductions as recommended by cppcheckAlan Coopersmith2-21/+18
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2023-03-19Convert to X.Org standard code styleAlan Coopersmith5-960/+942
Mostly via util/modular/x-indent-all.sh, plus some manual cleanup Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2023-03-08configure: Use LT_INIT from libtool 2 instead of deprecated AC_PROG_LIBTOOLAlan Coopersmith1-1/+2
AC_PROG_LIBTOOL was replaced by LT_INIT in libtool 2 in 2008, so it's time to rely on it. Clears autoconf warnings: configure.ac:33: warning: The macro `AC_PROG_LIBTOOL' is obsolete. configure.ac:33: You should run autoupdate. aclocal.m4:3465: AC_PROG_LIBTOOL is expanded from... configure.ac:33: the top level libtoolize: Consider adding 'AC_CONFIG_MACRO_DIRS([m4])' to configure.ac, libtoolize: and rerunning libtoolize and aclocal. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2023-02-09gitlab CI: stop requiring Signed-off-by in commitsAlan Coopersmith1-2/+2
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2023-02-06gitlab CI: Add libtool to required packagesAlan Coopersmith1-2/+2
At least until the autoconf build is dropped in favor of meson Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-06-19meson: Fix compatibility version and current version of meson build to be ↵Jeremy Huddleston Sequoia1-0/+2
compatible with autotools build Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
2022-03-26gitlab CI: add a basic build testAlan Coopersmith1-0/+174
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-03-26Make doc install path from meson match autotoolsAlan Coopersmith1-1/+1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-03-26libXvMC 1.0.13libXvMC-1.0.13Matt Turner2-2/+2
Signed-off-by: Matt Turner <mattst88@gmail.com>
2022-03-26meson: Fix typoMatt Turner1-1/+1
Signed-off-by: Matt Turner <mattst88@gmail.com>
2022-03-26autotools: fix Requires and Requires.Private in pkgconfigDylan Baker2-4/+4
This only applies to the autotools generated pkg-config files, as Meson does it's own dependency tracking for us.
2022-03-26meson: Add a meson build systemDylan Baker2-1/+110
This does everything the autotools based system does, including building both a static and shared version by default, though this can be controlled with meson's builtin `default_library` option.
2022-03-26editorconfig: add mesonDylan Baker1-0/+4
2022-03-26editorconfig: addDylan Baker1-0/+13
2022-03-26Build xz tarballs instead of bzip2Alan Coopersmith1-1/+1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-03-26Fix spelling/wording issuesAlan Coopersmith5-16/+16
Found by using: codespell --builtin clear,rare,usage,informal,code,names Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2019-09-24libXvMC 1.0.12libXvMC-1.0.12Adam Jackson1-1/+1
Signed-off-by: Adam Jackson <ajax@redhat.com>
2019-09-24vld: Provide <X11/extensions/vldXvMC.h> ourselfAdam Jackson3-2/+176
This header refers to libX11 types, it doesn't belong in xorgproto and has been moved to legacy in 2019.2. Supply it ourselves.
2019-08-15pkgconfig: Remove xv from xvmc.pcAdam Jackson1-2/+2
This library does not itself require libXv for anything.
2019-07-23Add a pkgconfig file for libXvMCWDylan Baker3-2/+15
Mesa needs to link with this for testing, as do others presumably. Having a pkg-config file makes this much easier Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110735 v2: - remove xv from Requires and Requires.private
2019-03-16libXvMC 1.0.11libXvMC-1.0.11Alan Coopersmith1-1/+1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2018-12-07Update configure.ac bug URL for gitlab migrationAlan Coopersmith1-1/+1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2018-11-19Update README for gitlab migrationAlan Coopersmith3-24/+20
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2018-09-22Fix sign comparison warnings for loop indexesAlan Coopersmith1-2/+2
XvMC.c: In function ‘XvMCListSurfaceTypes’: XvMC.c:124:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for(i = 0; i < rep.num; i++) { ^ XvMC.c: In function ‘XvMCListSubpictureTypes’: XvMC.c:185:26: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for(i = 0; i < rep.num; i++) { ^ Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2018-09-22Need to check for -1, not 0, to determine if shmat() failedAlan Coopersmith1-1/+1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2018-09-22Fix handling of shmKey in XvMCGetDRInfoNeha Gupta1-7/+17
If we store the result of shmget in a CARD32 (unsigned int), then checking if it returned -1 for an error by using >= 0 doesn't work. Also, once the request is flushed from the buffer (as XReply does), there's no guarantee the values in it are still valid, so it's better to rely on our local variable instead. Fixes: https://gitlab.freedesktop.org/xorg/lib/libxvmc/issues/1 Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2017-01-26autogen: add default patch prefixMihail Konev1-0/+3
Signed-off-by: Mihail Konev <k.mvc@ya.ru>
2017-01-26autogen.sh: use quoted string variablesEmil Velikov1-4/+4
Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent fall-outs, when they contain space. Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2017-01-26autogen.sh: use exec instead of waiting for configure to finishPeter Hutterer1-1/+1
Syncs the invocation of configure with the one from the server. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
2016-10-04libXvMC 1.0.10libXvMC-1.0.10Matthieu Herrb1-1/+1
Signed-off-by: Matthieu Herrb <matthieu.herrb@laas.fr>
2016-09-25Avoid buffer underflow on empty strings.Tobias Stoeckmann1-2/+2
If an empty string is received from an x-server, do not underrun the buffer by accessing "rep.nameLen - 1" unconditionally, which could end up being -1. Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org> Reviewed-by: Matthieu Herrb <matthieu@herrb.eu>
2015-03-14libXvMC 1.0.9libXvMC-1.0.9Alan Coopersmith1-1/+1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2013-12-14Rename local err variable in XW_RSYM macro to avoid shadow warningsAlan Coopersmith1-5/+5
Clears many warnings of the form: XvMCWrapper.c: In function 'initW': XvMCWrapper.c:362:5: warning: declaration of 'err' shadows a previous local [-Wshadow] XvMCWrapper.c:267:11: warning: shadowed declaration is here [-Wshadow] due to variable declared in macro block sharing "err" name with a variable declared in the function calling the macro. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2013-12-14Fix linking with -Wl,--no-undefined on LinuxYaakov Selkowitz2-1/+7
libXvMCW uses dlopen and friends, therefore it must be linked against libdl on systems where it exists as a separate library. Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net> Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2013-11-22Remove fallback for _XEatDataWords, require libX11 1.6 for itMichael Joost2-18/+1
_XEatDataWords was orignally introduced with the May 2013 security patches, and in order to ease the process of delivering those, fallback versions of _XEatDataWords were included in the X extension library patches so they could be applied to older versions that didn't have libX11 1.6 yet. Now that we're past that hurdle, we can drop the fallbacks and just require libX11 1.6 for building new versions of the extension libraries. Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2013-06-24Require ANSI C89 pre-processor, drop pre-C89 token pasting supportAlan Coopersmith1-13/+0
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2013-06-13libXvMC 1.0.8libXvMC-1.0.8Alan Coopersmith1-1/+1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2013-06-06avoid overflowing by making nameLen and busIDLen addition overflowJulien Cristau1-1/+3
Al Viro pointed this out on lwn: if nameLen + busIDLen overflows, we end up copying data from outside tmpBuf. Reported-by: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: Julien Cristau <jcristau@debian.org> Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2013-05-24Multiple unvalidated patches in CVE-2013-1999Dave Airlie1-3/+3
Al Viro pointed out that Debian started segfaulting in Xine for him, Reported-by: Al Viro Signed-off-by: Dave Airlie <airlied@redhat.com>
2013-04-26Multiple unvalidated assumptions in XvMCGetDRInfo() [CVE-2013-1999]Alan Coopersmith1-17/+19
The individual string sizes is assumed to not be more than the amount of data read from the network, and could cause buffer overflow if they are. The strings returned from the X server are assumed to be null terminated, and could cause callers to read past the end of the buffer if they are not. Also be sure to set the returned pointers to NULL, so callers don't try accessing bad pointers on failure cases. Reported-by: Ilja Van Sprundel <ivansprundel@ioactive.com> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2013-04-26integer overflow in _xvmc_create_*()Alan Coopersmith1-3/+6
rep.length is a CARD32 and should be bounds checked before left-shifting by 2 bits to come up with the total size to allocate, though in these cases, no buffer overflow should occur here, since the XRead call is passed the same rep.length << 2 length argument, but the *priv_count returned to the caller could be interpreted or used to calculate a larger buffer size than was actually allocated, leading them to go out of bounds. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2013-04-26integer overflow in XvMCListSubpictureTypes() [CVE-2013-1990 2/2]Alan Coopersmith1-2/+2
rep.num is a CARD32 and needs to be bounds checked before multiplying by sizeof(XvImageFormatValues) to come up with the total size to allocate, to avoid integer overflow leading to underallocation and writing data from the network past the end of the allocated buffer. Reported-by: Ilja Van Sprundel <ivansprundel@ioactive.com> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2013-04-26integer overflow in XvMCListSurfaceTypes() [CVE-2013-1990 1/2]Alan Coopersmith1-2/+2
rep.num is a CARD32 and needs to be bounds checked before multiplying by sizeof(XvMCSurfaceInfo) to come up with the total size to allocate, to avoid integer overflow leading to underallocation and writing data from the network past the end of the allocated buffer. Reported-by: Ilja Van Sprundel <ivansprundel@ioactive.com> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2013-04-13Use _XEatDataWords to avoid overflow of rep.length shiftingAlan Coopersmith2-6/+24
rep.length is a CARD32, so rep.length << 2 could overflow in 32-bit builds Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2013-01-15autogen.sh: Implement GNOME Build APIColin Walters1-1/+3
http://people.gnome.org/~walters/docs/build-api.txt Signed-off-by: Adam Jackson <ajax@redhat.com>
2013-01-15configure: Remove AM_MAINTAINER_MODEAdam Jackson1-1/+0
Signed-off-by: Adam Jackson <ajax@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-25 12:08:56 +0000