| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
|
|
For better or worse, we expose these to applications, so we should
namespace them. (This isn't purely theoretical: the names clash with the
same ones in Gibber within Salut.)
|
|
Gabble uses a couple of bits of this API to turn on a little bit of
Wocky's debug output for the purposes of the D-Bus debugging interface,
so making debug.h internal-only is not going to fly. However, most of it
really is internal-only.
|
|
|
|
|
|
|
|
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
Previously, passing from=NULL to wocky_porter_register_handler() made
the handler match stanzas with any sender. Unfortunately, this was
confused in a few places in Gabble—and once in WockyRoster, complete
with a FIXME—with matching messages from the server, which should have
no from='' attribute, or your own bare or full JID.
|
|
|
|
This makes Wocky closer to GAsyncResult conventions by using the _async
function as source tag instead of _finish. (Bug #26770)
|
|
For some reason recent ejabberd are sending 'error' messages when we publish
to a PEP node. That's probably an ejabberd bug (EJAB-1239) but Wocky should
ignore those rather than parsing them as actual PEP updates.
|
|
|
|
|
|
|
|
Rather than repeatedly calling that macro (which is reasonably
expensive), it should be called once in the object's _init() function
and stored in a pointer in the public structure. This patch changes the
whole of Wocky to do this correctly!
|
|
|
|
Unfortunately, the functions' previous signatures were awkward for
NULL-termination: because the first tag in the specification was an
explicit non-pointer argument, if you didn't actually want the stanza to
have a body you had to say:
wocky_xmpp_stanza_build_iq_result (..., WOCKY_STANZA_END, NULL);
You couldn't use NULL in place of WOCKY_STANZA_END because WockyBuildTag
isn't a pointer type; and you couldn't omit it because then the varargs
aren't NULL-terminated. So, this patch removes the explicit first tag
argument. While this may be slightly worse from a documentation point of
view, I think it's better than having to document the special case
above.
|
|
If 'reply' is NULL, we shouldn't set it as the operation result with
g_object_unref() as its destructor, since the latter doesn't like being
passed NULL. I've checked other uses of
g_simple_async_result_set_op_res_gpointer() in Wocky, and they're fine.
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
|
|
This brings it into line with the other make_foo_stanza() methods.
|
|
This will be useful in WockyPubsubNode as well as in WockyPepService.
|
|
|
|
|
|
|
|
|
|
|
