Diffstat (limited to 'Development/Documentation/SubmittingPatches.mdwn')
1 files changed, 6 insertions, 4 deletions
diff --git a/Development/Documentation/SubmittingPatches.mdwn b/Development/Documentation/SubmittingPatches.mdwn
index c56c419e..ce846712 100644
@@ -1,4 +1,3 @@
X.Org uses patches to do code development. This page describes the required format of a patch as well as the workflow to create, send and apply it. We assume you have a git cloned repository and are familiar with making code changes and commits.
Take a look at this [[example commit|http://cgit.freedesktop.org/xorg/xserver/commit/?id=9fe9b6e4ef669b192ee349e3290db5d2aeea273c]] from which this [[patch|http://lists.freedesktop.org/archives/xorg/2009-February/043171.html]] has been created. Open them in separate browser windows and refer to them while you read the rest of the page.
@@ -12,12 +11,14 @@ The patch submitter does the following:
* Commit code changes to the local repository using the [[git-commit|http://www.kernel.org/pub/software/scm/git/docs/git-commit.html]] command
* Create a patch using the [[git-format-patch|http://www.kernel.org/pub/software/scm/git/docs/git-format-patch.html]] command
-* E-mail the patch to the xorg-devel list using the [[git-send-email|http://www.kernel.org/pub/software/scm/git/docs/git-send-email.html]] command
+* E-mail the patch to the xorg-devel list using the [[git-send-email|http://www.kernel.org/pub/software/scm/git/docs/git-send-email.html]] command
The xorg-devel list reviewers do one of the following:
* Signify their approval or disapproval (Acked-by or Nacked-by)
* State an opinion about the appropriateness of the patch (Reviewed-by)
* Test the patch (Tested-by)
The module maintainer does the following:
* Obtain the patch from the bug report or from the xorg-devel list
@@ -154,7 +155,8 @@ X.Org developers may use a number of tags to acknowledge patches, both in a comm
* **Signed-off-by:** certifies that you wrote it or otherwise have the right to pass it on as a open-source patch.
* **Acked-by:** If a person was not directly involved in the preparation or handling of a patch but wishes to signify and record their approval of it then they can arrange to have an Acked-by: line. Acked-by: does not necessarily indicate acknowledgement of the entire patch.
* **Tested-by:** A Tested-by: tag indicates that the patch has been successfully tested (in some environment) by the person named. This tag informs maintainers that some testing has been performed, provides a means to locate testers for future patches, and ensures credit for the testers.
- * **Reviewed-by:** A Reviewed-by tag is a statement of opinion that the patch is an appropriate modification without any remaining serious technical issues. Any interested reviewer (who has done the work) can offer a Reviewed-by tag for a patch.
+ * **Reviewed-by:** A Reviewed-by tag is a statement of opinion that the patch is an appropriate modification without any remaining serious technical issues. Any interested reviewer (who has done the work) can offer a Reviewed-by tag for a patch.
Whenever you review a patch on the mailing list or in a bugzilla, feel free to provide the appropriate tag as a reply email (or a comment on bugzilla).
@@ -196,4 +198,4 @@ $> git send-email --to email@example.com 0001-*.patch
* [[List of Xorg maintainers|http://cgit.freedesktop.org/xorg/doc/xorg-docs/tree/MAINTAINERS]]
* [[Kernel patch submission process|http://kernelnewbies.org/UpstreamMerge/SubmittingPatches]]: details about patch format and contents equally apply to X.Org patches.
-* [[Git User's Manual|http://www.kernel.org/pub/software/scm/git/docs/user-manual.html]] \ No newline at end of file
+* [[Git User's Manual|http://www.kernel.org/pub/software/scm/git/docs/user-manual.html]]