diff options
| author | Lucas Tanure <tanure@linux.com> | 2015-09-30 09:38:37 -0300 |
|---|---|---|
| committer | Bryce Harrington <bryce@osg.samsung.com> | 2015-09-30 12:27:56 -0700 |
| commit | a3377cd1149bb0372f71b279e8bb1cb8427063dd (patch) | |
| tree | d44828b6e88c13df691b71c13a90aee8153b8cdf /ivi-shell/ivi-layout-transition.c | |
| parent | aa9747833efa6e9686ce3af0ec17afcf4efce342 (diff) | |
ivi-layout-transition: Standardize the check for layout_transition_register
Check the return from layout_transition_register in order to fix
potential leak of memory pointed to by transition. And don't register a
null transition.
Signed-off-by: Lucas Tanure <tanure@linux.com>
Reviewed-by: Bryce Harrington <bryce@osg.samsung.com>
Diffstat (limited to 'ivi-shell/ivi-layout-transition.c')
| -rw-r--r-- | ivi-shell/ivi-layout-transition.c | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/ivi-shell/ivi-layout-transition.c b/ivi-shell/ivi-layout-transition.c index adaa543c..483437db 100644 --- a/ivi-shell/ivi-layout-transition.c +++ b/ivi-shell/ivi-layout-transition.c @@ -418,7 +418,9 @@ ivi_layout_transition_move_resize_view(struct ivi_layout_surface *surface, transition_move_resize_view_destroy, duration); - layout_transition_register(transition); + if(transition && layout_transition_register(transition)) + return; + layout_transition_destroy(transition); } /* fade transition */ @@ -512,8 +514,9 @@ create_visibility_transition(struct ivi_layout_surface *surface, destroy_func, duration); - if (!layout_transition_register(transition)) - layout_transition_destroy(transition); + if (transition && layout_transition_register(transition)) + return; + layout_transition_destroy(transition); } static void |