summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorPeter Hutterer <peter.hutterer@who-t.net>2016-04-11 08:55:30 +1000
committerPeter Hutterer <peter.hutterer@who-t.net>2016-04-14 10:48:14 +1000
commitd76263a00fc0b82906043c276d93b7081f6ab81e (patch)
tree5f21cac750dc9e0f170329de9d27d477273168e3 /src
parent4f74f8e6851c7b17d2195e3cf3becfb100f36f3f (diff)
evdev: if we have a quick scroll button release, skip middle button emulation
The only difference between evdev_pointer_notify_physical_button() and evdev_pointer_notify_button() is that the former filters out middle button emulations where applicable. Doing so effectively disables using a button for scrolling that is also used for middle button emulation. This is intentional, it is a niche use-case (and prone to timer races). OTOH some devices exist that only have two buttons on the pointing stick and require button scrolling. This use-case is given preference. https://bugs.freedesktop.org/show_bug.cgi?id=94856 Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Diffstat (limited to 'src')
-rw-r--r--src/evdev.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/evdev.c b/src/evdev.c
index 28279433..aa5e68d4 100644
--- a/src/evdev.c
+++ b/src/evdev.c
@@ -507,11 +507,11 @@ evdev_button_scroll_button(struct evdev_device *device,
} else {
/* If the button is released quickly enough emit the
* button press/release events. */
- evdev_pointer_notify_physical_button(device,
+ evdev_pointer_notify_button(device,
device->scroll.button_down_time,
device->scroll.button,
LIBINPUT_BUTTON_STATE_PRESSED);
- evdev_pointer_notify_physical_button(device, time,
+ evdev_pointer_notify_button(device, time,
device->scroll.button,
LIBINPUT_BUTTON_STATE_RELEASED);
}