summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2019-12-19account: Fix property nameHEADmasterFlorian Müllner1-1/+1
Spaces are not valid characters in property names, and never were. Until recently GLib silently fixed up the name by replacing the space with '-', but now tightened up the validation.
2019-10-27Merge branch 'telepathy-mission-control-5.16'Alexander Akulich3-8/+38
2019-09-155.16.5telepathy-mission-control-5.16.5Alexander Akulich2-1/+18
2019-09-15Port make-release-mail.py to Python 3Alexander Akulich1-5/+5
2019-09-15Tools: Remove unused gquark-gen.pyAlexander Akulich2-136/+0
2019-09-15Tools: Remove glib-signals-marshal-genAlexander Akulich4-75/+0
See commit d70ba9ba46ea037b8003efc27de7f8c2d067befa in telepathy-glib. See also: https://bugs.freedesktop.org/show_bug.cgi?id=46523
2019-09-15Sync tools from telepathy-glibAlexander Akulich7-110/+128
2019-09-15Update telepathy.am from telepathy-glibAlexander Akulich1-1/+1
maintainer-prepare-release: do "git tag" in srcdir
2019-07-07McdAccount: Fix memory leak in get_parameter_of_known_type()Alexander Akulich1-0/+6
Based on a commit by Slava Monich <slava.monich@jolla.com>
2019-07-07Fix autoconnection of accounts with always_dispatch=trueMartin Klapetek1-1/+1
https://bugs.freedesktop.org/show_bug.cgi?id=91272
2019-07-07McdAccount: Fix memory leak in get_parameter_of_known_type()Alexander Akulich1-0/+6
Based on a commit by Slava Monich <slava.monich@jolla.com>
2019-07-07Fix autoconnection of accounts with always_dispatch=trueMartin Klapetek1-1/+1
https://bugs.freedesktop.org/show_bug.cgi?id=91272
2017-01-28Merge branch 'telepathy-mission-control-5.16'George Kiagiadakis12-39/+121
2017-01-28Fix string max size calculation.Tiago Salem Herrmann1-1/+1
Reviewed-by: George Kiagiadakis <gkiagia@tolabaki.gr> https://github.com/TelepathyIM/telepathy-mission-control/pull/1
2016-09-02nano flagGeorge Kiagiadakis1-1/+1
2016-09-025.16.4telepathy-mission-control-5.16.4George Kiagiadakis2-2/+3
2016-09-02dispatcher_delegate_channels: initialize amSimon McVittie1-1/+1
Otherwise, if we "goto error" too soon, we'll try to g_object_unref uninitialized memory. gcc doesn't spot that because we're using tp_clear_object, which uses an intermediate variable, and it doesn't propagate "uninitializedness" through assignments.
2016-09-02fix memory leaks: dbus_g_method_get_sender returns a copySimon McVittie2-7/+9
We were semi-consistently using it wrong.
2016-09-01Update NEWSGeorge Kiagiadakis1-0/+23
2016-09-01tests: fix race condition in account-manager/avatar.py testGeorge Kiagiadakis1-4/+2
It seems that the order of the dbus signals is unpredictable, so requiring it in the test sometimes makes it fail. It also seems that the other checks above in the same unit test have the same logic of not expecting a certain order in signal emission, so this is probably the right thing to do.
2016-09-01tests: make tests work again when NM support is enabledGeorge Kiagiadakis1-0/+22
Apparently the nm library also tries to access the /.../Settings object of NM, which was not available in our fake NM implementation. This commit implements the basic properties of the Settings object, which allows the tests to continue past this point. https://bugs.freedesktop.org/show_bug.cgi?id=96917
2016-07-18mc-wait-for-name: Call setlocale in main functionTing-Wei Lan1-0/+3
It is required to correctly show translated messages on some locales. https://bugs.freedesktop.org/show_bug.cgi?id=93661
2016-07-13configure: do not enable upower support if upower is >=0.99George Kiagiadakis1-1/+1
The code doesn't compile anymore, the features used have been removed. The replacement is logind, for which support exists in MC since 5.15.1. https://bugs.freedesktop.org/show_bug.cgi?id=70458
2016-07-13configure: bump glib version requirement to 2.46George Kiagiadakis1-3/+3
required for the fake-network-monitor in the unit tests https://bugs.freedesktop.org/show_bug.cgi?id=96763 Reviewed-by: Diane Trout <diane@ghic.org>
2016-07-13tests/twisted/fake-network-monitor: implement the "network-metered" and ↵George Kiagiadakis1-2/+14
"connectivity" properties of GNetworkMonitor "connectivity" is required since glib 2.44 "network-metered" is required since glib 2.46 https://bugs.freedesktop.org/show_bug.cgi?id=96763 Reviewed-by: Diane Trout <diane@ghic.org>
2016-07-03Don't initialize function pointers with G_TYPE_INVALIDTing-Wei Lan3-3/+3
https://bugs.freedesktop.org/show_bug.cgi?id=94310 Reviewed-by: George Kiagiadakis
2016-07-01connectivity-monitor.c: fix unused variable warning when compiling without ↵George Kiagiadakis1-14/+18
nm support This GError variable is not used anywhere else in this function.
2016-06-29libnm-glib is deprecated and may not be available.Diane Trout2-10/+5
This patch switches to use th enew libnm API, also snice nm_client_new now takes a GError, I thought I'd report the error message if mission control can't connect to the network manager. Additionally we can remove a definition of the NM_CHECK_VERSION macro for old versions of NM, as well as a guard for the NM_STATE_DISCONNECTING constant.
2014-08-28server: exit early if we failed to create McdServiceGuillaume Desmottes1-0/+2
mcd_service_new() can return NULL if we didn't manage to connect to D-Bus. Best to handle this gracefully rather than crashing horribly. This is the top crasher on Ubuntu btw. https://errors.ubuntu.com/problem/7e2a5f9a379f34a347895782ae948177926a1932
2014-08-25nano flagGuillaume Desmottes1-1/+1
2014-08-255.16.3telepathy-mission-control-5.16.3Guillaume Desmottes2-1/+8
2014-08-25mcd-connection: use tp_asv_new() properlySteffen Kieß1-1/+1
The second argument has to be the type of the value. https://bugs.freedesktop.org/show_bug.cgi?id=81751
2014-06-11nano flagGuillaume Desmottes1-1/+1
2014-06-115.16.2telepathy-mission-control-5.16.2Guillaume Desmottes2-2/+8
2014-06-11mcd_account_delete: make sure that the account stays aliveGuillaume Desmottes1-0/+5
Fix a regression introduced when backporting fix for https://bugs.freedesktop.org/show_bug.cgi?id=79827
2014-06-10Merge branch 'telepathy-mission-control-5.16'Guillaume Desmottes2-5/+27
Conflicts: src/mcd-account.c
2014-06-10mcd-account: unregister the account once we're done deleting itGuillaume Desmottes1-4/+26
The McdAccount object may still be alive for a short while because of pending async operations. We want to get rid of the D-Bus object as soon as possible and so, for example, a new Account object replacing the deleted one can be created. Fix https://bugs.freedesktop.org/show_bug.cgi?id=79827
2014-06-10use G_STRFUNC in mission-control-plugins's DEBUG macroGuillaume Desmottes1-1/+1
It's more useful when reading logs than G_STRLOC and that's what we already use in src/mcd-debug.h
2014-06-09mcd-storage: actually remove deleted accountsGuillaume Desmottes1-2/+6
https://bugs.freedesktop.org/show_bug.cgi?id=79832
2014-03-19Zero-initialize McdLoadAccountsDataSimon McVittie1-1/+1
Otherwise, holds_setup_lock is sometimes initially nonzero, making us think we have the setup lock when really we don't, and leading to an assertion failure when we try to release it. For some reason I could only reproduce this during distcheck... Reviewed-by: Xavier Claessens (cherry picked from commit 6a073b02dbfda060142f7d47426fec55c7caba0d)
2014-03-19run-test.sh: output in TAP format, and install an installed-tests wrapperSimon McVittie2-14/+33
See: https://wiki.gnome.org/action/show/Initiatives/GnomeGoals/InstalledTests https://en.wikipedia.org/wiki/Test_Anything_Protocol Bug: https://bugs.freedesktop.org/show_bug.cgi?id=74626 Reviewed-by: Guillaume Desmottes
2014-02-17McdAccount: Set "account-path-suffix" parameter on CMs that support itXavier Claessens1-0/+10
2014-02-06update documentation for McpAcccountStorageIface membersSimon McVittie1-3/+11
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=74581 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
2014-02-06McdStorage: watch and proxy plugins' change-notification signalsSimon McVittie5-349/+246
This lets us get rid of the "ready" vfunc on plugins: we now connect to each plugin's signals only after we have called mcp_account_storage_list(), so we won't get double-notification for accounts that are both present in the initial list and signalled. This means we can remove a queue of delayed signal emissions from the test D-Bus plugin (and when it's ported to this API, from Empathy's libaccounts/UOA plugin). As far as I can see, list() and ready() happen within the same main-loop iteration anyway, so I don't think it was even possible to receive notification of a new account in that window. Empathy's GNOME Online Accounts plugin never really implemented this: in theory, it was incorrect, since any account that happened to be added between list() and ready() would be lost altogether. However, list() and ready() seem to happen in the same main-loop iteration, so this might never have been a practical concern. Rather than "fixing" Empathy's GOA plugin, it seems better to remove the difficult case altogether. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=74581 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
2014-02-06McdAccountManager: if an account is async-added during setup, wait for itSimon McVittie1-0/+10
Previously, we'd only wait for accounts added in mcd_storage_load() to become ready. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=74581 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
2014-02-06McdAccountManager: ref the objects in McdLoadAccountsDataSimon McVittie1-3/+7
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=74581 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
2014-02-06mcd_keyfile_get_variant: add support for int16, uint16Simon McVittie1-0/+45
If we're opportunistically migrating parameters according to CM-specified types, we need to cope with uint16 ('q') for port numbers. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=71093 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
2014-02-06mcd_storage_maybe_migrate_parameters: fix error handlingSimon McVittie1-5/+1
mcp_account_storage_get_parameter() doesn't raise a GError. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=71093 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
2014-02-04NEWSSimon McVittie1-1/+7
2014-02-04Opportunistically migrate accounts from untyped to typed ParametersSimon McVittie6-19/+186
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=71093 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> [also depend on new tp-glib for tp_connection_manager_param_dup_variant_type -smcv]