From b47a9af03b3154401cdd863f6b76c2393e2e7e39 Mon Sep 17 00:00:00 2001 From: Simon McVittie Date: Fri, 7 Jun 2013 17:42:15 +0100 Subject: tp_debug_client_get_messages_finish: fix annotation Returning a GPtrArray with (transfer full) means the caller is expected to do the equivalent of: g_ptr_array_foreach (pa, (GFunc) g_free, NULL); g_ptr_array_unref (pa); whereas we just want them to unref it. This crashed my g-i-based debug-client. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=65518 Reviewed-by: Guillaume Desmottes --- telepathy-glib/debug-client.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/telepathy-glib/debug-client.c b/telepathy-glib/debug-client.c index 113ac3ff3..89712db40 100644 --- a/telepathy-glib/debug-client.c +++ b/telepathy-glib/debug-client.c @@ -536,8 +536,8 @@ tp_debug_client_get_messages_async ( * * Finishes tp_debug_client_set_enabled_async(). * - * Returns: (transfer full) (type GLib.PtrArray) (element-type TelepathyGLib.DebugMessage): - * a #GPtrArray of #TpDebugMessage + * Returns: (transfer container) (type GLib.PtrArray) (element-type TelepathyGLib.DebugMessage): + * a #GPtrArray of #TpDebugMessage, free with g_ptr_array_unref() * * Since: 0.19.0 */ -- cgit v1.2.3 From 65cfeebe29bdd85fa7b72856ce93b900f7af1539 Mon Sep 17 00:00:00 2001 From: Simon McVittie Date: Mon, 10 Jun 2013 14:49:31 +0100 Subject: NEWS for 0.20 --- NEWS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/NEWS b/NEWS index ccc0da4d0..b817f4aa2 100644 --- a/NEWS +++ b/NEWS @@ -3,6 +3,9 @@ telepathy-glib 0.20.3 (UNRELEASED) Fixes: +• Fix a wrong introspection annotation on tp_debug_client_get_messages_finish() + that would lead to use-after-free (fd.o #65518, Simon) + • Isolate regression tests better (fd.o #63119, Simon) • Explicitly annotate tp_account_update_parameters_finish()'s -- cgit v1.2.3