Age | Commit message (Collapse) | Author | Files | Lines |
|
This breaks the console plugin, which checks if an entered stanza is of
a known type, but <message xmlns=''> is not the same as <message
xmlns='jabber:client'> so Wocky now says the former has type UNKNOWN.
The plugin already had some code to fix up empty namespaces, but it's
after the type check. For a better fix, I added API to give
non-streaming WockyXmppReaders a default namespace, and used it here.
In the course of fixing this, I found that telling the console to send
this:
<message>
<body>
hai
</body>
</message>
would send this:
<message xmlns='jabber:client'>
<body xmlns=''>
hai
</body>
</message>
which is wrong: the empty namespace was not being fixed up recursively.
This is fixed as a side-effect of the default-namespace property, but
this patch also adds a test.
https://bugs.freedesktop.org/show_bug.cgi?id=57016
|
|
Conflicts:
NEWS
configure.ac
src/conn-addressing.c
src/jingle-info.c
src/media-channel-hold.c
src/message-util.c
src/muc-tube-dbus.c
src/muc-tube-stream.c
src/olpc-activity.c
src/presence-cache.c
src/protocol.c
src/room-config.c
|
|
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=49384
|
|
Gabble still uses emit_new_channels and tp_handle_{,un}ref, but for
now we can ignore it with this. config.h had to be included in the
right place for a lot of source files.
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=49596
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
|
|
|
|
This lets you configure the plugin directory:
./configure pluginexecdir='${libdir}/my-gabble-plugins'
The directory-name variable has 'exec' in it because Automake installs
unknown directory names with 'exec' in their variable name during
"make install-exec", and other unknown directory names during
"make install-data".
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=46417
Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
Reviewed-by: Olli Salli <olli.salli@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=46417
|
|
Gabble and Salut Plugin API was updated to remove the dupliate
TpBaseconnection from create_channel_managers. This patch updates
the plugin-base to match the API change
|
|
Using -module doesn't produce .dll files when compiling for windows
These changes enable us to output .dll files for plugins.
https://bugs.freedesktop.org/show_bug.cgi?id=44649
|
|
library
This patch refactors gabble connection by introducing a new GInterface
which the plugins will link agaist. And GabbleConnection implements the
new Interface.
https://bugs.freedesktop.org/show_bug.cgi?id=44649
|
|
All gabble plugins should implement these two methods hereafter.
This patch also updates all the internal plugins to use this new API.
https://bugs.freedesktop.org/show_bug.cgi?id=44331
|
|
https://bugs.freedesktop.org/show_bug.cgi?id=27489
|
|
This reverts commit bf805ba0b2ecced81e5c2830a79d021a42da91a7, reversing
changes made to 1296a2f5ce46e77787ca42eadb1c2ca4a957a09b.
|
|
This reverts commit a687785628216f8f73c699096e9aae4a07b811c6, reversing
changes made to bf805ba0b2ecced81e5c2830a79d021a42da91a7.
|
|
Conflicts:
lib/loudmouth/Makefile.am
plugins/console.c
src/Makefile.am
src/connection.c
src/error.c
src/plugin-loader.c
src/plugin.c
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
Conflicts:
lib/loudmouth/Makefile.am
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
Using -module doesn't produce .dll files when compiling for windows
These changes enable us to output .dll files for plugins.
https://bugs.freedesktop.org/show_bug.cgi?id=44649
|
|
library
This patch refactors gabble connection by introducing a new GInterface
which the plugins will link agaist. And GabbleConnection implements the
new Interface.
https://bugs.freedesktop.org/show_bug.cgi?id=44649
|
|
All gabble plugins should implement these two methods hereafter. This patch also updates
all the internal plugins to use this new API
https://bugs.freedesktop.org/show_bug.cgi?id=44331
|
|
All gabble plugins should implement these two methods hereafter. This patch also updates
all the internal plugins to use this new API
https://bugs.freedesktop.org/show_bug.cgi?id=44331
|
|
In gobject-introspection we trust.
https://bugs.freedesktop.org/show_bug.cgi?id=44056
|
|
Fixes: <https://bugs.freedesktop.org/show_bug.cgi?id=xmpp-console>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
The traffic monitor window will need to show nicely-formatted stanzas,
and it will also need a grid with the same spacing.
|
|
|
|
This just pulls out the entire Gtk.Grid containing the UI for sending an
IQ into its own subclass of Gtk.Grid, paving the way for another page in
the UI for watching the stanzas fly past.
|
|
Ideally the SpewStanzas property would become False when the client
which asked for it falls off the bus. Later...
|
|
|
|
|
|
|
|
|
|
I'd like to use a combobox or something for the get/set selection.
|
|
It is only installed if the plugin is installed.
|
|
|
|
It currently only supports sending an arbitrary IQ and getting the
reply. Obviously this is for developer use only.
|
|
Replace g_(ptr_)array_free (foo, TRUE) and g_hash_table_destroy
with respectively g_(ptr_)array_unref (foo) and g_hash_table_unref.
I used this command to generate this patch:
for f in `find -name "*.c"`; do sed -i $f -re 's/g_ptr_array_free \(([^ ,]+), TRUE\)/g_ptr_array_unref \(\1\)/'; done
See Danielle's blog for explanation of possible bug _free can do:
http://blogs.gnome.org/danni/2011/11/16/mistakes-with-g_value_set_boxed/
|
|
|
|
...and give back a new data form in the represent_client function.
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
|
|
If the test plugin's channel manager holds a reference to the
connection, we have a cycle: the connection owns a reference to each
channel manager. TpBaseConnection only releases its channel managers
when it's disposed, which in this case is never.
(All the other channel managers do the right thing.)
Fixes: <https://bugs.freedesktop.org/show_bug.cgi?id=36179>
|
|
The spec requires that the fixed properties of any requestable channel
class include ChannelType and TargetHandleType. (Actually, we violate
the latter for ContactSearch, but the former seems like a pretty
reasonable thing to conform to.) The test plugin did not respect this:
in fact, none of the fixed or allowed properties were valid D-Bus
property names.
Anyway, some of the Jingle tests rely on ChannelType being present in
every channel class. This seems basically reasonable to me.
I did not catch this in my review.
|
|
|