tests: filter: check rules from string

Simple limits and parsing checks to usbredirfilter_string_to_rules()

Signed-off-by: Victor Toso <victortoso@redhat.com>

3 files changed, 119 insertions, 0 deletions

diff --git a/meson.build b/meson.build
index 952ec55..c615081 100644
--- a/meson.build
+++ b/meson.build
@@ -105,6 +105,7 @@ if host_machine.system() != 'windows'
         subdir('fuzzing')
     endif
 endif
+subdir('tests')
 subdir('data')
 
 summary(summary_info, bool_yn: true)
diff --git a/tests/filter.c b/tests/filter.c
new file mode 100644
index 0000000..be1058b
--- /dev/null
+++ b/tests/filter.c
@@ -0,0 +1,103 @@
+/*
+ * Copyright 2021 Red Hat, Inc.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, see <http://www.gnu.org/licenses/>.
+*/
+
+#include <locale.h>
+#include <glib.h>
+#include <stdlib.h>
+
+#include "usbredirfilter.h"
+
+static void
+test_verify_rules_bad(void)
+{
+    int i;
+    const char * const filters[] = {
+        /* Check upper and lower limits */
+        "0x100,-1,-1,-1,0", /* class */
+        "-2,-1,-1,-1,0",
+        "0x03,,0x10000-1,-1,0", /* vendor */
+        "0x03,-2,-1,-1,0",
+        "0x03,-1,0x10000-1,,0", /* product */
+        "0x03,-1,-2,-1,0",
+        "0x03,-1,-1,0x10000,0", /* bcd */
+        "0x03,-1,-1,-2,0",
+        /* Extra argument */
+        "0x03,-1,-1,-1,0,1",
+        /* Missing argument */
+        "0x03,-1,-1,-1",
+        /* Missing value in argument */
+        "0x03,-1,-1,,-1",
+        /* Bad char as value in argument (1) */
+        "0x03,-1,-1,a,-1",
+        /* Bad char as value in argument (2) */
+        "0x03,-1,-1,#,-1",
+        /* Bad char as value in argument (3) */
+        "0x03,-1,-1, ,-1",
+        /* Invalid token_sep */
+        "0x03;-1;-1;-1;0",
+        /* Invalid rule_sep */
+        "0x03,-1,-1,-1,0;-1,-1,-1,-1,1",
+        /* Bad rule in many */
+        "0x03,-1,-1,-1,0|3|-1,-1,-1,-1,1",
+    };
+
+    for (i = 0; i < G_N_ELEMENTS (filters); i++) {
+        int retval, count = 0;
+        struct usbredirfilter_rule *rules = NULL;
+
+        retval = usbredirfilter_string_to_rules(filters[i], ",", "|", &rules, &count);
+        g_assert_cmpint(retval, ==, -EINVAL);
+        g_assert_null(rules);
+    }
+}
+
+static void
+test_verify_rules_good(void)
+{
+    int i;
+    struct {
+        int nrules;
+        const char *filter;
+    } test_data[] = {
+        { 1, "0x03,-1,-1,-1,0" },
+        { 2, "0x03,-1,-1,-1,0|-1,-1,-1,-1,1" },
+        { 2, "|0x03,-1,-1,-1,0|-1,-1,-1,-1,1|" }, /* Ignores trailing rule_sep */
+        { 2, "0x03,-1,-1,-1,0|||-1,-1,-1,-1,1" }, /* Ignores empty rules */
+    };
+
+    for (i = 0; i < G_N_ELEMENTS (test_data); i++) {
+        int retval, count = 0;
+        struct usbredirfilter_rule *rules = NULL;
+
+        retval = usbredirfilter_string_to_rules(test_data[i].filter, ",", "|", &rules, &count);
+        g_assert_cmpint(retval, ==, 0);
+        g_assert_cmpint(count, ==, test_data[i].nrules);
+        free(rules);
+    }
+}
+
+int
+main(int argc, char **argv)
+{
+    setlocale(LC_ALL, "");
+    g_test_init(&argc, &argv, NULL);
+
+    g_test_add_func("/filter/rules/good", test_verify_rules_good);
+    g_test_add_func("/filter/rules/bad", test_verify_rules_bad);
+
+    return g_test_run();
+}
diff --git a/tests/meson.build b/tests/meson.build
new file mode 100644
index 0000000..0d4397b
--- /dev/null
+++ b/tests/meson.build
@@ -0,0 +1,15 @@
+tests = [
+    'filter',
+]
+
+deps = dependency('glib-2.0')
+
+foreach t: tests
+    source = t + '.c'
+    runtime = 'test-' + t
+    exe = executable(runtime,
+        [source],
+        install: false,
+        dependencies: [deps, usbredir_parser_lib_dep])
+    test(runtime, exe, timeout:10)
+endforeach