summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHans de Goede <hdegoede@redhat.com>2012-02-12 15:50:36 +0100
committerHans de Goede <hdegoede@redhat.com>2012-02-14 18:56:08 +0100
commitdf5b37a3c3409a8d686fecbb8cee1d84e357f8d3 (patch)
tree60ce91f341448e63ad0b66902da86f5fe2b1c3ae
parente509ebd5995db826e741a3481d10130f41156600 (diff)
usbredirhost: No need to keep the lock when freeing a transfer
Remove the wrong comment and move the free outside the locked part of the function. Signed-off-by: Hans de Goede <hdegoede@redhat.com>
-rw-r--r--usbredirhost/usbredirhost.c6
1 files changed, 1 insertions, 5 deletions
diff --git a/usbredirhost/usbredirhost.c b/usbredirhost/usbredirhost.c
index b9988eb..6bd28ea 100644
--- a/usbredirhost/usbredirhost.c
+++ b/usbredirhost/usbredirhost.c
@@ -722,12 +722,8 @@ static void usbredirhost_remove_and_free_transfer(
transfer->next->prev = transfer->prev;
if (transfer->prev)
transfer->prev->next = transfer->next;
- /*
- * The free must be done with the lock held, see
- * usbredirhost_cancel_data_packet().
- */
- usbredirhost_free_transfer(transfer);
UNLOCK(host);
+ usbredirhost_free_transfer(transfer);
}
/* Called from close and parser read callbacks */