diff options
| author | Frediano Ziglio <fziglio@redhat.com> | 2018-02-23 10:11:12 +0000 |
|---|---|---|
| committer | Frediano Ziglio <fziglio@redhat.com> | 2018-03-10 07:15:44 +0000 |
| commit | 235ac173495096730dff6fff16bea42790d4c703 (patch) | |
| tree | a00d87de0eb55c11068af59acbffa0d1e9dd9c68 | |
| parent | bd279b1fc1f7e5fc32a7e440223f7ef58b6e51e0 (diff) | |
stream-device: Specify how padding shoud be inside new structures
Depending on how structures are initialised in the code is
possible that implicit padding bytes are not initialised
causing possible information leaks as the entire structure
with all padding is sent through device/network.
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Acked-by: Christophe de Dinechin <dinechin@redhat.com>
| -rw-r--r-- | spice/stream-device.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/spice/stream-device.h b/spice/stream-device.h index 2e7c50e..b2f83b5 100644 --- a/spice/stream-device.h +++ b/spice/stream-device.h @@ -48,6 +48,8 @@ * containing integers up to 64 bit. * All numbers are in little endian format. * + * For security reasons structures should not contain implicit paddings. + * * The protocol can be defined by these states: * - Initial. Device just opened. Guest should wait * for a message from the host; |