From 591235c8b6c65a2eee88991b9ae73490fd9afdfe Mon Sep 17 00:00:00 2001 From: Albert Astals Cid Date: Wed, 17 May 2023 22:42:05 +0200 Subject: OutlineItem::open: Fix crash on malformed files Fixes #1399 --- poppler/Outline.cc | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/poppler/Outline.cc b/poppler/Outline.cc index cbb6cb49..4c68be99 100644 --- a/poppler/Outline.cc +++ b/poppler/Outline.cc @@ -14,7 +14,7 @@ // under GPL version 2 or later // // Copyright (C) 2005 Marco Pesenti Gritti -// Copyright (C) 2008, 2016-2019, 2021 Albert Astals Cid +// Copyright (C) 2008, 2016-2019, 2021, 2023 Albert Astals Cid // Copyright (C) 2009 Nick Jones // Copyright (C) 2016 Jason Crain // Copyright (C) 2017 Adrian Johnson @@ -483,8 +483,12 @@ void OutlineItem::open() { if (!kids) { Object itemDict = xref->fetch(ref); - const Object &firstRef = itemDict.dictLookupNF("First"); - kids = readItemList(this, &firstRef, xref, doc); + if (itemDict.isDict()) { + const Object &firstRef = itemDict.dictLookupNF("First"); + kids = readItemList(this, &firstRef, xref, doc); + } else { + kids = new std::vector(); + } } } -- cgit v1.2.3