summaryrefslogtreecommitdiff
path: root/goo
diff options
context:
space:
mode:
authorAdam Reichold <adam.reichold@t-online.de>2018-10-10 07:44:58 +0200
committerAdam Reichold <adam.reichold@t-online.de>2018-10-10 07:46:44 +0200
commit7f20ace4579f69fc3bd0f975fadec37134c3782c (patch)
tree28c4e2c3ee913d7aa8ccb151a50c17ef2f658530 /goo
parente1501603b6f043a40586ff0babf34980a6f03b15 (diff)
Remove usage of pragmas interface and implementation
GCC recommends not using them for a long time and its documentation says: > These #pragmas have been superceded as of GCC 2.7.2 by COMDAT support > and the “key method” heuristic mentioned in Vague Linkage. > Using them can actually cause your program to grow due to > unnecessary out-of-line copies of inline functions. Also nobody seems to set USE_GCC_PRAGMAS and sometimes they were guarded by just __GNUC__ which upsets Clang.
Diffstat (limited to 'goo')
-rw-r--r--goo/FixedPoint.cc4
-rw-r--r--goo/FixedPoint.h4
-rw-r--r--goo/GooString.cc4
-rw-r--r--goo/GooString.h4
-rw-r--r--goo/GooTimer.cc4
-rw-r--r--goo/GooTimer.h4
6 files changed, 0 insertions, 24 deletions
diff --git a/goo/FixedPoint.cc b/goo/FixedPoint.cc
index b51446bf..565b86c2 100644
--- a/goo/FixedPoint.cc
+++ b/goo/FixedPoint.cc
@@ -26,10 +26,6 @@
#ifdef USE_FIXEDPOINT
-#ifdef USE_GCC_PRAGMAS
-#pragma implementation
-#endif
-
#include "FixedPoint.h"
#define ln2 ((FixedPoint)0.69314718)
diff --git a/goo/FixedPoint.h b/goo/FixedPoint.h
index 408dfc6f..a7b406ec 100644
--- a/goo/FixedPoint.h
+++ b/goo/FixedPoint.h
@@ -30,10 +30,6 @@
#ifdef USE_FIXEDPOINT
-#ifdef USE_GCC_PRAGMAS
-#pragma interface
-#endif
-
#include <stdio.h>
#include <stdlib.h>
#include "gtypes.h"
diff --git a/goo/GooString.cc b/goo/GooString.cc
index 6a625e2b..42bf604e 100644
--- a/goo/GooString.cc
+++ b/goo/GooString.cc
@@ -35,10 +35,6 @@
#include <config.h>
-#ifdef USE_GCC_PRAGMAS
-#pragma implementation
-#endif
-
#include <stdlib.h>
#include <stddef.h>
#include <string.h>
diff --git a/goo/GooString.h b/goo/GooString.h
index 1eca4bc3..4755526a 100644
--- a/goo/GooString.h
+++ b/goo/GooString.h
@@ -33,10 +33,6 @@
#ifndef GooString_H
#define GooString_H
-#ifdef USE_GCC_PRAGMAS
-#pragma interface
-#endif
-
#include <stdarg.h>
#include <stdlib.h> // for NULL
#include <string>
diff --git a/goo/GooTimer.cc b/goo/GooTimer.cc
index b1161853..42295a48 100644
--- a/goo/GooTimer.cc
+++ b/goo/GooTimer.cc
@@ -13,10 +13,6 @@
#include <config.h>
-#ifdef USE_GCC_PRAGMAS
-#pragma implementation
-#endif
-
#include "GooTimer.h"
#include <string.h>
diff --git a/goo/GooTimer.h b/goo/GooTimer.h
index ac64f6b4..be0b6ff1 100644
--- a/goo/GooTimer.h
+++ b/goo/GooTimer.h
@@ -17,10 +17,6 @@
#ifndef GOOTIMER_H
#define GOOTIMER_H
-#ifdef USE_GCC_PRAGMAS
-#pragma interface
-#endif
-
#include "poppler-config.h"
#include "gtypes.h"
#ifdef HAVE_GETTIMEOFDAY