Fix "NSS could not shutdown"

SignatureHandler never freed it's signing certificate. This left
an internal NSS reference that prevented cleanup of the NSS cache,
causing "NSS could not shutdown".

NSS maintains an internal in-memory cache, where content is reference
counted. PK11_MakeCertFromHandle increases the issuerAndSn count.
CERT_DestroyCertificate decreases it. NSS tries to destruct the cache in
NSS_Shutdown, which we've scheduled with atexit. There it detects a
remaining reference.

Fixes #1326.

1 files changed, 4 insertions, 0 deletions

diff --git a/poppler/SignatureHandler.cc b/poppler/SignatureHandler.cc
index 3cf40973..89bcc5dd 100644
--- a/poppler/SignatureHandler.cc
+++ b/poppler/SignatureHandler.cc
@@ -858,6 +858,10 @@ SignatureHandler::~SignatureHandler()
         HASH_Destroy(hash_context);
     }
 
+    if (signing_cert) {
+        CERT_DestroyCertificate(signing_cert);
+    }
+
     free(temp_certs);
 }