diff options
| author | Albert Astals Cid <aacid@kde.org> | 2023-05-17 22:42:05 +0200 |
|---|---|---|
| committer | Albert Astals Cid <tsdgeos@yahoo.es> | 2023-05-17 20:43:18 +0000 |
| commit | 591235c8b6c65a2eee88991b9ae73490fd9afdfe (patch) | |
| tree | 5694319495494eddd7eb881baad060caac63b331 | |
| parent | db6d86238a86116f4ef809d6fd19ed859c36b5c1 (diff) | |
OutlineItem::open: Fix crash on malformed files
Fixes #1399
| -rw-r--r-- | poppler/Outline.cc | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/poppler/Outline.cc b/poppler/Outline.cc index cbb6cb49..4c68be99 100644 --- a/poppler/Outline.cc +++ b/poppler/Outline.cc @@ -14,7 +14,7 @@ // under GPL version 2 or later // // Copyright (C) 2005 Marco Pesenti Gritti <mpg@redhat.com> -// Copyright (C) 2008, 2016-2019, 2021 Albert Astals Cid <aacid@kde.org> +// Copyright (C) 2008, 2016-2019, 2021, 2023 Albert Astals Cid <aacid@kde.org> // Copyright (C) 2009 Nick Jones <nick.jones@network-box.com> // Copyright (C) 2016 Jason Crain <jason@aquaticape.us> // Copyright (C) 2017 Adrian Johnson <ajohnson@redneon.com> @@ -483,8 +483,12 @@ void OutlineItem::open() { if (!kids) { Object itemDict = xref->fetch(ref); - const Object &firstRef = itemDict.dictLookupNF("First"); - kids = readItemList(this, &firstRef, xref, doc); + if (itemDict.isDict()) { + const Object &firstRef = itemDict.dictLookupNF("First"); + kids = readItemList(this, &firstRef, xref, doc); + } else { + kids = new std::vector<OutlineItem *>(); + } } } |