diff options
| author | Oliver Sander <oliver.sander@tu-dresden.de> | 2022-08-31 11:07:14 +0200 |
|---|---|---|
| committer | Oliver Sander <oliver.sander@tu-dresden.de> | 2022-08-31 16:26:45 +0200 |
| commit | 0c9bfb401780d6e05adba58e03c3dbdfa44c9895 (patch) | |
| tree | 97400922dfdd3f2be917aaa06a1d90abdb317676 | |
| parent | 9a3d991e62ba936495780007132299d73f3d603b (diff) | |
Store 'gfx' as a std::unique_ptr
Otherwise it will leak if charProc is not a stream (line 488).
Found by
https://sonarcloud.io/project/overview?id=tsdgeos_poppler_mirror
| -rw-r--r-- | poppler/CairoFontEngine.cc | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/poppler/CairoFontEngine.cc b/poppler/CairoFontEngine.cc index 0f6191e6..841e9efd 100644 --- a/poppler/CairoFontEngine.cc +++ b/poppler/CairoFontEngine.cc @@ -445,7 +445,6 @@ static cairo_status_t _render_type3_glyph(cairo_scaled_font_t *scaled_font, unsi double wx, wy; PDFRectangle box; type3_font_info_t *info; - Gfx *gfx; cairo_status_t status; info = (type3_font_info_t *)cairo_font_face_get_user_data(cairo_scaled_font_get_font_face(scaled_font), &type3_font_key); @@ -480,7 +479,7 @@ static cairo_status_t _render_type3_glyph(cairo_scaled_font_t *scaled_font, unsi box.y1 = mat[1]; box.x2 = mat[2]; box.y2 = mat[3]; - gfx = new Gfx(info->doc, output_dev, resDict, &box, nullptr); + auto gfx = std::make_unique<Gfx>(info->doc, output_dev, resDict, &box, nullptr); output_dev->startDoc(info->doc, info->fontEngine); output_dev->startType3Render(gfx->getState(), gfx->getXRef()); output_dev->setInType3Char(true); @@ -521,7 +520,6 @@ static cairo_status_t _render_type3_glyph(cairo_scaled_font_t *scaled_font, unsi status = CAIRO_STATUS_USER_FONT_NOT_IMPLEMENTED; } - delete gfx; delete output_dev; return status; |