From 47a52576da74f58f550eba3a1d1c1fdea7015d85 Mon Sep 17 00:00:00 2001 From: Mike Blumenkrantz Date: Wed, 8 Jun 2022 13:52:47 -0400 Subject: zink: always create descriptor templates the 'notemplates' debug mode is somewhat misleading since there's no uncached+notemplates mechanism, meaning that if the descriptor cache explodes it'll still use templates for updating in the fallback path Fixes: 4e3768914d4 ("zink: add ZINK_DESCRIPTORS env var to explicitly set a mode") Reviewed-by: Dave Airlie Part-of: (cherry picked from commit ee1a0a0772d0aaf4f5124d451f6a087bc6910b58) --- .pick_status.json | 2 +- src/gallium/drivers/zink/zink_descriptors_lazy.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.pick_status.json b/.pick_status.json index f1ee1aab896..2e7a06f175b 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -1381,7 +1381,7 @@ "description": "zink: always create descriptor templates", "nominated": true, "nomination_type": 1, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": "4e3768914d4ca226041e121b8b80b2daa7b5aa64" }, diff --git a/src/gallium/drivers/zink/zink_descriptors_lazy.c b/src/gallium/drivers/zink/zink_descriptors_lazy.c index 2a596b810af..cae24c90929 100644 --- a/src/gallium/drivers/zink/zink_descriptors_lazy.c +++ b/src/gallium/drivers/zink/zink_descriptors_lazy.c @@ -282,7 +282,8 @@ zink_descriptor_program_init_lazy(struct zink_context *ctx, struct zink_program pg->layout = zink_pipeline_layout_create(screen, pg, &pg->compat_id); if (!pg->layout) return false; - if (!screen->info.have_KHR_descriptor_update_template || screen->descriptor_mode == ZINK_DESCRIPTOR_MODE_NOTEMPLATES) + /* TODO: figure out uncached+notemplate and return on screen->descriptor_mode == ZINK_DESCRIPTOR_MODE_NOTEMPLATES */ + if (!screen->info.have_KHR_descriptor_update_template) return true; VkDescriptorUpdateTemplateCreateInfo template[ZINK_DESCRIPTOR_TYPES + 1] = {0}; -- cgit v1.2.3