From 2736370294427d87933ce7ae293e0465fbab77e2 Mon Sep 17 00:00:00 2001 From: Erik Faye-Lund Date: Thu, 22 Apr 2021 13:46:41 +0200 Subject: docs: do not generate redirects on error The build-finished event is also triggered when there's an error. I somehow got the second argument wrong, and ended up ignoring the case. This can lead to new exceptions being thrown due to missing files, that ends up hiding the real problem. Fixes: 64a4ba9e1ce ("docs: add an extension to generate redirects") Reviewed-by: Eric Engestrom Part-of: --- docs/_exts/redirects.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/_exts/redirects.py b/docs/_exts/redirects.py index 90d69efee5f..1adf3cdb8ab 100644 --- a/docs/_exts/redirects.py +++ b/docs/_exts/redirects.py @@ -6,8 +6,8 @@ def create_redirect(dst): tpl = '' return tpl.format(dst) -def create_redirects(app, docname): - if not app.builder.name == 'html': +def create_redirects(app, exception): + if exception is not None or not app.builder.name == 'html': return for src, dst in app.config.html_redirects: path = os.path.join(app.outdir, '{0}.html'.format(src)) -- cgit v1.2.3