diff options
| author | Jose Maria Casanova Crespo <jmcasanova@igalia.com> | 2018-06-09 11:46:07 +0200 |
|---|---|---|
| committer | Jose Maria Casanova Crespo <jmcasanova@igalia.com> | 2018-06-16 22:39:08 +0200 |
| commit | 8003ae87f43f92fd74e29cba6c5fcd0739ce95db (patch) | |
| tree | d73a6c91eeb0dcd0ffe99134239ba25687a7205f /src | |
| parent | 5565630f8542544a8be550f0b52751cfa724a84e (diff) | |
intel/fs: shuffle_from_32bit_read at load_per_vertex_input at TCS/TES
Previously, the shuffle function had a source/destination overlap that
needs to be avoided to use shuffle_from_32bit_read. As we can use for
the shuffle destination the destination of removed MOVs.
This change also avoids the internal MOVs done by the previous shuffle
to deal with possible overlaps.
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
Diffstat (limited to 'src')
| -rw-r--r-- | src/intel/compiler/brw_fs_nir.cpp | 22 |
1 files changed, 8 insertions, 14 deletions
diff --git a/src/intel/compiler/brw_fs_nir.cpp b/src/intel/compiler/brw_fs_nir.cpp index 7fdc9313d15..352d50e74db 100644 --- a/src/intel/compiler/brw_fs_nir.cpp +++ b/src/intel/compiler/brw_fs_nir.cpp @@ -2665,13 +2665,10 @@ fs_visitor::nir_emit_tcs_intrinsic(const fs_builder &bld, * or SSBOs. */ if (type_sz(dst.type) == 8) { - shuffle_32bit_load_result_to_64bit_data( - bld, dst, retype(dst, BRW_REGISTER_TYPE_F), num_components); - - for (unsigned c = 0; c < num_components; c++) { - bld.MOV(offset(orig_dst, bld, iter * 2 + c), - offset(dst, bld, c)); - } + shuffle_from_32bit_read(bld, + offset(orig_dst, bld, iter * 2), + retype(dst, BRW_REGISTER_TYPE_D), + 0, num_components); } /* Copy the temporary to the destination to deal with writemasking. @@ -3014,13 +3011,10 @@ fs_visitor::nir_emit_tes_intrinsic(const fs_builder &bld, * or SSBOs. */ if (type_sz(dest.type) == 8) { - shuffle_32bit_load_result_to_64bit_data( - bld, dest, retype(dest, BRW_REGISTER_TYPE_F), num_components); - - for (unsigned c = 0; c < num_components; c++) { - bld.MOV(offset(orig_dest, bld, iter * 2 + c), - offset(dest, bld, c)); - } + shuffle_from_32bit_read(bld, + offset(orig_dest, bld, iter * 2), + retype(dest, BRW_REGISTER_TYPE_D), + 0, num_components); } /* If we are loading double data and we need a second read message |