path: root/src/mapi
diff options
authorMario Kleiner <>2015-03-12 23:34:12 +0100
committerEmil Velikov <>2015-03-26 01:47:11 +0000
commitd6413ed98fe07479d16cd2033d5379e06e5ce6d7 (patch)
tree2de5583e27a9276d83671dcb1436af78f4802040 /src/mapi
parent3147f0bd25c45c9bd2a2b1fec622eb1821e11df8 (diff)
mapi: Make private copies of name strings provided by client.
glXGetProcAddress("glFoo") ends up in stub_add_dynamic() to create dynamic stubs for dynamic functions. stub_add_dynamic() doesn't store the caller provided name string "Foo" in a mesa private copy, but just stores a pointer to the "glFoo" string passed to glXGetProcAddress - a pointer into arbitrary memory outside mesa's control. If the caller passes some dynamically allocated/changing memory buffer to glXGetProcAddress(), or the caller gets unmapped from memory, e.g., some dynamically loaded application plugin which uses OpenGL, this ends badly - with a dangling pointer. strdup() the name string provided by the client to avoid this problem. Cc: "10.3 10.4 10.5" <> Signed-off-by: Mario Kleiner <> Reviewed-by: Brian Paul <> (cherry picked from commit 1110113a7f0b6f9b21dd26dee8e95a021041c71c)
Diffstat (limited to 'src/mapi')
1 files changed, 1 insertions, 1 deletions
diff --git a/src/mapi/stub.c b/src/mapi/stub.c
index dfadbe1a5d3..45ccc6a3acf 100644
--- a/src/mapi/stub.c
+++ b/src/mapi/stub.c
@@ -110,7 +110,7 @@ stub_add_dynamic(const char *name)
if (!stub->addr)
return NULL;
- stub->name = (const void *) name;
+ stub->name = (const void *) strdup(name);
/* to be fixed later */
stub->slot = -1;